882863 - When typing words in fast the auto-corrections are sometimes skipped

Status: RESOLVED WONTFIX

(Firefox OS Graveyard :: Gaia::Keyboard, defect)

Description

[Francis Djabri [:djabber]]

When typing fast sometimes the auto-correction just doesn't work. 

E.g., I type in "uodate" - and it left as it was, even though "update" is the suggested item.

Similarly, I can type "Juky"  - even though July was the auto-correct suggestion

Comment 1

[Greg Weng [:snowmantw][:gweng][:λ]]

How fast did you type ? I can type these words normally with auto-corrections both in the built-in browser and message app.

Comment 2

[Greg Weng [:snowmantw][:gweng][:λ]]

(In reply to Greg Weng [:snowmantw] from comment #1)
> How fast did you type ? I can type these words normally with
> auto-corrections both in the built-in browser and message app.

I'm using a Unagi/1.1.0-prerelease device.

Comment 3

[Stephany Wilkes]

I am removing the flag for Francis since he filed this bug and is already copied on it.

Comment 4

[Tim Guan-tin Chien [:timdream] (please needinfo)]

This is a very old but it's still valid. The reason this happens is because we do not wait for the suggestion worker to return before processing the next key in latin.js.

I can try to do some measurement and see how this could affect the speed of typing.

Comment 5

[Tim Guan-tin Chien [:timdream] (please needinfo)]

Attachment: Patch for adding log

Here is my test and result. I hit some random keys w/o actually typing words:

sendKey: 33.6ms console.js:65
sendKey: 55.13ms console.js:65
predictions: 62.02ms latin.js:288
sendKey: 31.37ms console.js:65
predictions: 70.66ms latin.js:288
sendKey: 15.21ms console.js:65
predictions: 8.66ms latin.js:288
sendKey: 64.8ms console.js:65
sendKey: 10.35ms console.js:65
predictions: 19.93ms latin.js:288
sendKey: 106.55ms console.js:65
predictions: 44.76ms latin.js:288
sendKey: 124.23ms console.js:65
predictions: 13.52ms latin.js:288
sendKey: 111.21ms console.js:65
predictions: 5.52ms latin.js:288
sendKey: 66.3ms console.js:65

So although our sendKey() API does not perform well, it's possible the prediction takes more time than the API; therefore it's possible for prediction engine to delay the handling of the keys.

With that I don't think we should be able to fix this bug anytime soon.

Comment 6

[BMO Automation]

Firefox OS is not being worked on