Closed
Bug 882890
Opened 11 years ago
Closed 11 years ago
WebGL : vertex attribute array 0 should be disable by default
Categories
(Core :: Graphics: CanvasWebGL, defect)
Core
Graphics: CanvasWebGL
Tracking
()
RESOLVED
FIXED
mozilla24
People
(Reporter: guillaume.abadie, Assigned: guillaume.abadie)
Details
Attachments
(1 file, 1 obsolete file)
1.11 KB,
patch
|
bjacob
:
review+
RyanVM
:
checkin+
|
Details | Diff | Splinter Review |
vertex attribute array 0 should be disable by default
Assignee | ||
Updated•11 years ago
|
Assignee: nobody → gabadie
Assignee | ||
Comment 1•11 years ago
|
||
patch fixing the issue and get passing a WebGL conformance test 1.0.2
Attachment #762323 -
Flags: review?(bjacob)
Updated•11 years ago
|
Attachment #762323 -
Attachment is patch: true
Attachment #762323 -
Attachment mime type: text/x-patch → text/plain
Comment 2•11 years ago
|
||
Comment on attachment 762323 [details] [diff] [review] patch Review of attachment 762323 [details] [diff] [review]: ----------------------------------------------------------------- This doesn't fix what you say it fixes. Rather, it just pretends that the GL state is set properly. Is there a reason we can't just use the driver's value?
Assignee | ||
Comment 3•11 years ago
|
||
Actually it fix it : In the WebGL conformance test https://www.khronos.org/registry/webgl/conformance-suites/1.0.2/conformance/state/gl-get-calls.html , it fix the only one FAIL remaining "context.getVertexAttrib(ii, context.VERTEX_ATTRIB_ARRAY_ENABLED) should be false. Was true.". This test just check if all vertex attribute are disable right after the WebGL context creation. Actually, desktop OpenGL driver don't draw anything when the vertex attribute 0 is disable. But WebGL specifications authorize to draw with the vertex attribute 0 disabled. Therefor the WebGL layer always enable it, and fake the disable action of it. But this fake technique has been forgotten in that function. So this patch fix it, passing and the conformance test. That why this patch is very tiny.
Comment 4•11 years ago
|
||
Alright, please leave a comment there saying as much.
Updated•11 years ago
|
Attachment #762323 -
Flags: review?(bjacob) → review+
Comment 5•11 years ago
|
||
(In reply to Jeff Gilbert [:jgilbert] from comment #2) > Comment on attachment 762323 [details] [diff] [review] > patch > > Review of attachment 762323 [details] [diff] [review]: > ----------------------------------------------------------------- > > This doesn't fix what you say it fixes. Rather, it just pretends that the GL > state is set properly. Is there a reason we can't just use the driver's > value? The OpenGL value is different from the WebGL one because of vertex attrib 0 on desktop GL.
Assignee | ||
Comment 6•11 years ago
|
||
enhancing the patch comment for landing
Attachment #762323 -
Attachment is obsolete: true
Attachment #763547 -
Flags: review?(bjacob)
Updated•11 years ago
|
Attachment #763547 -
Flags: review?(bjacob) → review+
Updated•11 years ago
|
Attachment #763547 -
Flags: checkin?
Comment 8•11 years ago
|
||
Comment on attachment 763547 [details] [diff] [review] patch for landing Please just use checkin-needed in the future :)
Attachment #763547 -
Flags: checkin? → checkin+
Comment 9•11 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/9b5816c7fa6e
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla24
You need to log in
before you can comment on or make changes to this bug.
Description
•