882916 - [Email] Forward/Reply/Reply All functionality breaks on structured clone failure when e-mail sender already exists and has been cached

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::E-Mail, defect, P1)

Description

[Mila Davydova]

Attachment: logcat

Description:
When user taps on "Forward" button, while being in Message view, the email app freezes and user is not able to perform any actions, until the app is killed and relaunched again.

Repro Steps:
1) Updated to Leo Build ID: 20130610070206
2) Open one of the emails from the account's Inbox 
3) Tap on the "Forward" button
4) Tap on any other buttons in the message View screen

Actual:
- A New Compose Message view does not open and user is not able to forward selected email message
- Email app freezes, and user is not able to perform any actions, until email app is killed and relaunched again

Expected:
- A New Compose Message View opens and user is able to forward the email message 
- Email app resumes in its normal state 

Environmental Variables
Gecko: http://hg.mozilla.org/releases/mozilla-b2g18/rev/8e3f39363c54
Gaia: ce3b99781d182ad550a325206990c249b0dbcf0e
Platform Version: 18.0

Notes:
Repro frequency: 100%
Test Suite Name: Email
UCID: email-127
Link to failed test case: https://moztrap.mozilla.org/runtests/run/1475/env/314/?pagenumber=1&pagesize=20&sortfield=order&sortdirection=asc&filter-id=2911
Q Analysts Team Priority: (Pri Levels: Pri 2
See attached: logcat for more info
Issue reproduces on both Gmail and Hotmail accounts

Comment 1

[Tracy Walker [:tracy]]

This works for me on Leo device with:
Gecko  http://hg.mozilla.org/releases/mozilla-b2g18/rev/d85aa34a49f2
Gaia   0198c8980b454deb965830a729d5951952daf010
BuildID 20130613070213
Version 18.0

Comment 2

[Andrew Sutherland [:asuth] (he/him)]

The terrifying (and not particularly useful) message in the logcat is this:
I/GeckoDump(2197): [31mERR: onerror reporting: Error: Permission denied to access object @ app://email.gaiamobile.org/gaia_build_defer_index.js : 775[0m

No other error messages jumped out at me.

I'm currently unable to reproduce on a 20130612070210 unagi/1.1.0/beta build.


Because of the minifier in use and the non-specific error message it's hard to tell exactly what the bad line was, but a quick skim implied it was postMessage bridge related.

Mila, was:
- the message an HTML message?
- the sender of the message in question in the address book?

Was any other functionality broken in the e-mail app?

Comment 3

[Mila Davydova]

(In reply to Andrew Sutherland (:asuth) from comment #2)

Yes. Looks like this issue only happens with the email messages, where the sender's email is saved in the address book. 
If the email of the sender is not saved in the address book, user is able to forward the message.
Looks like the type of email message does not make a difference.

Comment 4

[John Hammink]

Mila, in regards to your comment 3, can you restate the *exact* preconditions, STR and rate of repro.   Include a Video, for example, and logcat as supporting evidence.  If we can repro this, it's a leo blocker.

Comment 5

[Mila Davydova]

Preconditions:
- Have a Gmail account set up on the device 
- Create a contact with email address in the address book (Contacts app) and
receive an email from that contact)

STR: 
1) Go to Inbox Folder
2) Open an email message from the contact saved in the address book
3) Tap on the “Forward” button
4) Tap on any other buttons in the Message View screen

Attaching video for more info: 
 http://www.youtube.com/watch?v=qUg4S1VO5NM&feature=youtu.be

Comment 6

[Mila Davydova]

Attachment: email/forward logcat

Comment 7

[Andrew Sutherland [:asuth] (he/him)]

Attachment: email app with debugging turned up to dangerous levels, logged in realtime

I'm having real trouble reproducing this bug, so I've created a modified version of the e-mail app that turns a *lot* of debugging on.  This debugging will necessarily include potentially sensitive data because internal data structures are under suspicion.  As such, you should probably just directly e-mail me any logs at [e-mail] *assuming there is no data in the account in question that it's not okay for me to see*.  If there is sensitive data, you'll need to reproduce the bug on a testing account with no sensitive data or manually redact the contents of the log.

To get the app up on your device, you'll want to do something like the following:
adb push application.zip /data/local/webapps/email.gaiamobile.org/application.zip

To get the logging, you'll want to run the following PRIOR to starting the e-mail app:

adb logcat -f OUTPUTFILENAME -s GeckoDump:V Gecko:V

Obviously, use a path you can write to for OUTPUTFILENAME.


The changes in the app correspond to the commit I made on my "crazy-verbose-logging" branch:
https://github.com/asutherland/gaia-email-libs-and-more/tree/crazy-verbose-logging

Comment 8

[Andrew Sutherland [:asuth] (he/him)]

(Also, the app is not minified because the minification was making things more confusing than they needed to be.)

Comment 9

[Mila Davydova]

Also, same exact issue happens when user attempts to reply to the email, the address of which was previously saved in the address book.
When user taps on "Reply" and "Reply to all" buttons, the email app freezes and user is not able to perform any actions, until the app is killed and relaunched again.

Comment 10

[Andrew Sutherland [:asuth] (he/him)]

But this *only* happens if the sender is a contact?

Will you be able to run with the version of the e-mail app I mentioned in comment 7?

Comment 11

[Mila Davydova]

(In reply to Andrew Sutherland (:asuth) from comment #10)

Hi Abdrew.

Yes, this issue reproduces only if the sender's email address is saved in contacts.

I sent you an email with the logs I got, after reproducing this issue with the version of the email app that you've mentioned in comment 7. 
Let me know if you need any extra info from me.

Comment 12

[psingapati]

I have also sent the logs to your email id.
Please check.

If secret debug mode log helps in this situation, please let me know I will send you.

Thanks.

Comment 13

[Andrew Sutherland [:asuth] (he/him)]

(In reply to psingapati from comment #12)
> I have also sent the logs to your email id.
> Please check.

I've checked the logs you provided.  Unfortunately, it doesn't look like you were running with the build of the app I attached on the bug.  However, Mila has provided good logs from that build that I'm going to look at shortly.  (Team meetings the past few days have taken up a lot of time.)

Comment 14

[psingapati]

One more observation found for this issue.

when we add a contact from Message viewer and perform forward or reply or reply all it is working fine. Issue is not reproduced. But if we kill the application and comes back to email app , view any email which has sender in contacts, the issue is reproducible when we try to forward or reply or reply all.

Comment 15

[bhavana bajaj [:bajaj]]

(In reply to Andrew Sutherland (:asuth) from comment #13)
> (In reply to psingapati from comment #12)
> > I have also sent the logs to your email id.
> > Please check.
> 
> I've checked the logs you provided.  Unfortunately, it doesn't look like you
> were running with the build of the app I attached on the bug.  However, Mila
> has provided good logs from that build that I'm going to look at shortly. 
> (Team meetings the past few days have taken up a lot of time.)

Hey :asuth , just checking if the provided  logs were useful for your investigation and in case you had any update on this bug ?

Comment 16

[Andrew Sutherland [:asuth] (he/him)]

I've identified the problem; the bug is in resolvePeep code in the 'hit' path.  We end up storing the DOMStringList instead of its 0th element in this code path, but we are correct in other code paths.  This is not a regression after all, which caused some of the problems.

I'll add more test coverage and have a fix up tonight for review.

Comment 17

[Andrew Sutherland [:asuth] (he/him)]

Attachment: Pointer to Github pull request: https://github.com/mozilla-b2g/gaia-email-libs-and-more/pull/221

Pointer to Github pull-request

Comment 18

[James Lal [:lightsofapollo]]

Comment on attachment 767030 [details]
Pointer to Github pull request: https://github.com/mozilla-b2g/gaia-email-libs-and-more/pull/221

Looks good but see my comments

Comment 19

[Andrew Sutherland [:asuth] (he/him)]

landed in gaia-email-libs-and-more/master:
https://github.com/mozilla-b2g/gaia-email-libs-and-more/pull/221
https://github.com/mozilla-b2g/gaia-email-libs-and-more/commit/e56ef2cf86bd0991f1ed39e4371fcd8e899fc6cf

landed in gaia/master:
https://github.com/mozilla-b2g/gaia/pull/10619
https://github.com/mozilla-b2g/gaia/commit/4fafcace2ad0063a2f7125c57374d3985a4ba7fa

Comment 20

[Gareth Aye [:gaye] (back from PTO)]

Uplifted 4fafcace2ad0063a2f7125c57374d3985a4ba7fa to:
v1-train: c439a7468a0fdce5aec41876cfef73c2063195b6

Comment 21

[John Ford [:jhford] CET/CEST Berlin Time]

v1.1.0hd: c439a7468a0fdce5aec41876cfef73c2063195b6