882937 - GTest dependency don't support adding/removing files

Status: RESOLVED FIXED

(Firefox Build System :: General, defect)

Description

[Benoit Girard (:BenWa)]

I noticed when adding more tests to GTest that adding/removing files doesn't trigger a rebuild. This is a regression from bug 844288.

The build system considers gfx/test/gtest to be a component linked in libxul but the dependency don't pick up that a new file should be added to the list.

How do we support this?

Comment 1

[Gregory Szorc [:gps]]

Can you be more specific about what's not rebuilding? The libxul-test library isn't being relinked?

Comment 2

[Benoit Girard (:BenWa)]

Yes. The new object file is build but since it's not in toolkit/library/.deps/gtest/XUL (mac path) it doesn't get relinked. How does regular libxul detect that new files were added and that it needs to relink?

Comment 3

[Mike Hommey [:glandium]]

(In reply to Benoit Girard (:BenWa) from comment #2)
> How does regular libxul detect that new files were added and that it needs to relink?

By having dependencies on .desc files, one of which should have been updated to contain the new file.

Comment 4

[Benoit Girard (:BenWa)]

Attachment: Fix Deps

Looks like I messed up the dependency when applying the review comment.

DLL_SUFFIX includes the '.' and it's not redefined when generating a framework.

Comment 5

[Benoit Girard (:BenWa)]

https://tbpl.mozilla.org/?tree=Try&rev=da73ac8fcf95

Comment 6

[Benoit Girard (:BenWa)]

Attachment: Fix Deps

Removed debugging echo

Comment 7

[Benoit Girard (:BenWa)]

Attachment: Fix Deps

Comment 8

[Benoit Girard (:BenWa)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/62f26a2bab83

Comment 9

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/62f26a2bab83