882940 - Add Ctrl-L as a synonym for /clear

Status: RESOLVED FIXED

(Other Applications Graveyard :: ChatZilla, defect)

Description

[Matěj Cepl]

If I get some hints how to attach a command to a shortcut, it should be trivial I guess to write a patch. But alas! I don't know how to do it. Could anybody help?

Comment 1

[:Gijs (he/him)]

https://hg.mozilla.org/chatzilla/file/945f7a1efd97/locales/en-US/chrome/chatzilla.properties

You essentially just want to find cmd.clear in there, and add

cmd.clear.key = accel L

I think that's all it should take. There's a python script in the root of the project that'll generate an XPI package with which you can test your changes.

Comment 2

[Matěj Cepl]

Attachment: suggested patch

> cmd.clear.key = accel L

Well, cmd.clear-view.key, but otherwise, it is that. Thank you.

Comment 3

[:Gijs (he/him)]

Comment on attachment 762662 [details] [diff] [review]
suggested patch

I think I suggested most of this, so it's probably better if this gets an OK from James.

Comment 4

[James Ross]

Comment on attachment 762662 [details] [diff] [review]
suggested patch

Review of attachment 762662 [details] [diff] [review]:
-----------------------------------------------------------------

My only concerns are that this provides users with an unrecoverable accident shortcut key. We can always pull it out or change the key if it proves to be a problem though, so I'm okaying this.

Comment 5

[Matěj Cepl]

Is that correct?

Comment 6

[Matěj Cepl]

(In reply to James Ross from comment #4)
> My only concerns are that this provides users with an unrecoverable accident
> shortcut key. We can always pull it out or change the key if it proves to be
> a problem though, so I'm okaying this.

Well, more thorough solution would be to on first use rise up a dialog asking to switch on logs, I guess. But this could do for now.

Comment 7

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/chatzilla/rev/1d276f21c199