Closed
Bug 882948
Opened 11 years ago
Closed 11 years ago
Add widget level support for AeroLite
Categories
(Core :: Widget: Win32, defect)
Tracking
()
RESOLVED
FIXED
mozilla24
People
(Reporter: ehsan.akhgari, Assigned: ehsan.akhgari)
References
Details
Attachments
(1 file)
3.37 KB,
patch
|
roc
:
review+
|
Details | Diff | Splinter Review |
Windows Server 2012 and 2013's theme is AeroLite, and we currently fail to recognize it properly.
Assignee | ||
Comment 1•11 years ago
|
||
Comment 2•11 years ago
|
||
Don't forget about media queries in nsMediaFeatures.cpp - http://mxr.mozilla.org/mozilla-central/source/layout/style/nsMediaFeatures.cpp#31
Blocks: 882345
Attachment #762355 -
Flags: review?(roc) → review+
Assignee | ||
Comment 3•11 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/7c68efe0675b
Assignee | ||
Comment 4•11 years ago
|
||
(In reply to Jim Mathies [:jimm] from comment #2) > Don't forget about media queries in nsMediaFeatures.cpp - > > http://mxr.mozilla.org/mozilla-central/source/layout/style/nsMediaFeatures. > cpp#31 Argh! https://hg.mozilla.org/integration/mozilla-inbound/rev/2501f979d629
Comment 5•11 years ago
|
||
The patches use both "lite" and "light". I think we should use "lite" consistently to match what Windows calls the theme unless there is a good reason for this.
Flags: needinfo?(ehsan)
Assignee | ||
Comment 6•11 years ago
|
||
(In reply to Matthew N. [:MattN] from comment #5) > The patches use both "lite" and "light". I think we should use "lite" > consistently to match what Windows calls the theme unless there is a good > reason for this. Embarrassing: https://hg.mozilla.org/integration/mozilla-inbound/rev/5e5abccab73e
Flags: needinfo?(ehsan)
Assignee | ||
Comment 7•11 years ago
|
||
Forgot the other half that actually matters: https://hg.mozilla.org/integration/mozilla-inbound/rev/0004b0e5b946 :(
Comment 8•11 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/7c68efe0675b https://hg.mozilla.org/mozilla-central/rev/2501f979d629 https://hg.mozilla.org/mozilla-central/rev/5e5abccab73e https://hg.mozilla.org/mozilla-central/rev/0004b0e5b946
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla24
Updated•11 years ago
|
relnote-firefox:
--- → ?
Updated•11 years ago
|
relnote-firefox:
? → ---
You need to log in
before you can comment on or make changes to this bug.
Description
•