882975 - Fix duplicate "max-height" declaration in flexbox-sizing-vert-1.xhtml

Status: RESOLVED FIXED

(Core :: Layout, defect)

Description

[Daniel Holbert [:dholbert]]

biesi pointed out that flexbox-sizing-vert-1.xhtml has two max-heights specified:
37       div.c {
38         flex: 1 40px;
39         max-height: 10px;
40         max-height: 60px;
41         background: orange;
42       }
http://mxr.mozilla.org/mozilla-central/source/layout/reftests/w3c-css/submitted/flexbox/flexbox-sizing-vert-1.xhtml#37

Filing this bug to clean that up. (Either converting the smaller one to min-height, or just dropping one. I forget what I originally intended. Need to take a closer look.)

Comment 1

[Daniel Holbert [:dholbert]]

This affects flexbox-sizing-horiz-1.xhtml , too (with s/height/width/):
35       div.c {
36         flex: 1 40px;
37         max-width: 10px;
38         max-width: 60px;
39         background: orange;
40       }
http://mxr.mozilla.org/mozilla-central/source/layout/reftests/w3c-css/submitted/flexbox/flexbox-sizing-horiz-1.xhtml#37

Comment 2

[Daniel Holbert [:dholbert]]

Attachment: patch

Here's a patch to fix this (with s/max/min/ on the lower value) & tweak the reference cases accordingly.

Reftest still passes locally. Try run to be sure it passes elsewhere, too:
 https://tbpl.mozilla.org/?tree=Try&rev=1cf939ac7d47

Comment 3

[Daniel Holbert [:dholbert]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/52c16e7e867c

Comment 4

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/52c16e7e867c

Comment 5

[Daniel Holbert [:dholbert]]

dbaron, would you mind re-syncing the w3c-css reftest directory, to get this fixed in the w3c copy of these tests?

Comment 6

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

http://hg.csswg.org/test/rev/c88a96071aac