883002 - Add a mozbrowseropensearch event to mozbrowser iframes to allow discovery of OpenSearch providers

Status: RESOLVED FIXED

(Firefox OS Graveyard :: General, defect)

Description

[Robert Kaiser]

We should support OpenSearch providers in the B2G browser. This may be on the browser or system level, not 100% sure.

See discussion in bug 808732 comment #22 and following.

This probably is the right way to do things like users changing search engines (bug 808732) and supporting multiple search engines (bug 879235).

Comment 1

[[:fabrice] Fabrice Desré]

We will need some additional support from the mozbrowser API here.

Comment 4

[Robert Kaiser]

I think OpenSearch should still be mentioned in the summary here as it is *the* open, cross-browser standard already in existence for that.

Comment 5

[ffos-browser]

A Pivotal Tracker story has been created for this Bug: http://www.pivotaltracker.com/story/show/53546479

Comment 6

[[:fabrice] Fabrice Desré]

Attachment: patch

This patch adds a 'mozbrowseropensearch' event that sends back the title and href of the search engine.

Try build at: https://tbpl.mozilla.org/?tree=Try&rev=a1e7aa8a3bb4

Comment 7

[[:fabrice] Fabrice Desré]

Attachment: patch v2

Updated patch, with tests now passing.

Comment 8

[Justin Lebar (not reading bugmail)]

Comment on attachment 778354 [details] [diff] [review]
patch v2

Looks good to me.

>diff --git a/dom/browser-element/mochitest/browserElement_Opensearch.js b/dom/browser-element/mochitest/browserElement_Opensearch.js

FYI this is a pretty old style of test; nowadays we have more clever ways of
doing things (using alert and promises, among other things).  It doesn't matter
for this copypasta, but if you were going to write a test from scratch, I'd say
to avoid this style.

Comment 9

[[:fabrice] Fabrice Desré]

https://hg.mozilla.org/projects/birch/rev/5dfb22ea0888

Comment 10

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/5dfb22ea0888

Comment 11

[Ben Francis [:benfrancis]]

Renaming to more accurately reflect the platform (not user facing) feature that was added in this patch.

Comment 12

[ffos-browser]

Ben Francis deleted the linked story in Pivotal Tracker

Comment 13

[Chris Mills [:cmills]]

documented here:

https://developer.mozilla.org/en-US/docs/Web/Events/mozbrowseropensearch