Closed
Bug 883002
Opened 11 years ago
Closed 11 years ago
Add a mozbrowseropensearch event to mozbrowser iframes to allow discovery of OpenSearch providers
Categories
(Firefox OS Graveyard :: General, defect)
Firefox OS Graveyard
General
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: kairo, Assigned: fabrice)
References
Details
(Keywords: dev-doc-complete, feature, uiwanted, Whiteboard: [UCID: Browser12, FT:Browser, KOI:P2])
Attachments
(1 file, 1 obsolete file)
|
13.07 KB,
patch
|
justin.lebar+bug
:
review+
|
Details | Diff | Splinter Review |
We should support OpenSearch providers in the B2G browser. This may be on the browser or system level, not 100% sure. See discussion in bug 808732 comment #22 and following. This probably is the right way to do things like users changing search engines (bug 808732) and supporting multiple search engines (bug 879235).
|
Assignee | |
Comment 1•11 years ago
|
||
We will need some additional support from the mozbrowser API here.
|
||
Updated•11 years ago
|
|
Reporter | |
Comment 4•11 years ago
|
||
I think OpenSearch should still be mentioned in the summary here as it is *the* open, cross-browser standard already in existence for that.
Summary: Allow user to add multiple search providers → Allow user to add multiple search providers (via OpenSearch)
|
||
Comment 5•11 years ago
|
||
A Pivotal Tracker story has been created for this Bug: http://www.pivotaltracker.com/story/show/53546479
|
|
Assignee | |
Comment 6•11 years ago
|
||
This patch adds a 'mozbrowseropensearch' event that sends back the title and href of the search engine. Try build at: https://tbpl.mozilla.org/?tree=Try&rev=a1e7aa8a3bb4
Assignee: nobody → fabrice
|
|
Assignee | |
Comment 7•11 years ago
|
||
Updated patch, with tests now passing.
Attachment #777843 -
Attachment is obsolete: true
Attachment #778354 -
Flags: review?(justin.lebar+bug)
|
||
Comment 8•11 years ago
|
||
Comment on attachment 778354 [details] [diff] [review] patch v2 Looks good to me. >diff --git a/dom/browser-element/mochitest/browserElement_Opensearch.js b/dom/browser-element/mochitest/browserElement_Opensearch.js FYI this is a pretty old style of test; nowadays we have more clever ways of doing things (using alert and promises, among other things). It doesn't matter for this copypasta, but if you were going to write a test from scratch, I'd say to avoid this style.
Attachment #778354 -
Flags: review?(justin.lebar+bug) → review+
|
|
Assignee | |
Comment 9•11 years ago
|
||
https://hg.mozilla.org/projects/birch/rev/5dfb22ea0888
Component: Gaia::Browser → General
|
||
Comment 10•11 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/5dfb22ea0888
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
|
|
||
Comment 11•11 years ago
|
||
Renaming to more accurately reflect the platform (not user facing) feature that was added in this patch.
Summary: Allow user to add multiple search providers (via OpenSearch) → Add a mozbrowseropensearch event to mozbrowser iframes to allow discovery of OpenSearch providers
|
|
||
Comment 12•11 years ago
|
||
Ben Francis deleted the linked story in Pivotal Tracker
|
|
Assignee | |
Updated•11 years ago
|
Keywords: dev-doc-needed
|
||
Updated•11 years ago
|
Whiteboard: [UCID: Browser12, FT:Browser, KOI:P2]
|
||
Comment 13•9 years ago
|
||
documented here: https://developer.mozilla.org/en-US/docs/Web/Events/mozbrowseropensearch
Keywords: dev-doc-needed → dev-doc-complete
You need to log in
before you can comment on or make changes to this bug.
Description
•