883024 - the frame size of Video element is not properly set.

Status: RESOLVED FIXED

(Firefox OS Graveyard :: General, defect, P1)

Description

[Leo]

1. Title:[Browser] Video frame size is not properly set.
2. Precondition: Browser is working. 
3. Tester's Action:  (1) Open a website containing direct linked video
                     (2) Click on a video link to start playing
                     (3) Observe that video will be start playing in embedded player 
4. Detailed Symptom (ENG.) : Video frame size is not adjusted to the screen size.
5. Expected: Video frame size is properly adjusted to the screen size.
6. Reproducibility: Y
1) Frequency Rate : 100%
7. Gaia Master/v1-train: Reproduced on v1-train and master 
8. Gaia Revision:  bd07ce233160a0e6325bf736769772a9d2273458

Comment 1

[John Hu [:johnhu][:johu][:醬糊小弟]]

Is it possible to give us the video and screenshot??

Comment 2

[jeremy.kim.leo [:jeremykimleo]]

Attachment: imdb.com's main page

Comment 3

[jeremy.kim.leo [:jeremykimleo]]

Attachment: not screen fit

Comment 4

[jeremy.kim.leo [:jeremykimleo]]

add more information

STR>
browser -> 
http://m.imdb.com -> 
start playing one of trailers video on the top of this page.
in this case, video is "Elysium" (refer to imdb.com's main page of attachments)

video screen fits to horizontal screen. so, it is oversized on portraite mode.

Comment 5

[John Hu [:johnhu][:johu][:醬糊小弟]]

Jeremy,

Thanks for your STR. It does what you say. This video is not handled by video app but video element of browser.

Comment 6

[Alex Keybl [:akeybl]]

Over to blassey for reassignment (hope that functional group -> mgr mapping is correct)

Comment 7

[Jinho Hwang [:jeffhwang]]

Hi all, I'd like to suggest small thing to fix this bug.
Here are ..
 1. Adjust the controller size for video element to the size of viewport.
    Since we open a video element in browser, we can zoom in/out the content. 
    I think it's good UX and the performance is good enough. 
    But the problem here is the controller. 
    It must fit to the size of viewport but currently it fits the size of controller to  size of content. That's why user can not see the whole controller.
     
 2. Adjust the zoom rate for the video element when user open it first time.
    Currently, when we open the video in browser, the zoom rate is 1.0. It means the video element get the real size of the content and doesn't fit to the viewport.

Please, consider this. 
thank you.

Comment 8

[Dale Harvey (:daleharvey)]

Taking a look at this, so the video player is a document loaded by 

http://mxr.mozilla.org/mozilla-central/source/content/html/document/src/VideoDocument.cpp

and uses https://github.com/mozilla/mozilla-central/blob/master/layout/style/TopLevelVideoDocument.css

This is the same code used for firefox desktop and firefox android, in both of which the content works fine (it also works as expected on b2g desktop). On the device however we have various rendering errors, the viewport is set incorrectly, on rotating the video the entire background turns white, the pan and zoom lets us move the content outside where it should be possible and the video width it set incorrectly.

Given that the code is fine and desktop, android and b2g desktop are working, there must be a layout issue, need infoing, Robert do you have any idea what could be causing this document to act so wrong on firefox os devices?

Comment 9

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Try adding to http://mxr.mozilla.org/mozilla-central/source/content/html/document/src/VideoDocument.cpp creation of a <meta viewport> tag to disable scaling by the browser?

Comment 10

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Er, disable scaling and panning/zooming.

Comment 11

[Dale Harvey (:daleharvey)]

Just an update while I am debugging

We set the meta viewport size correctly (although do not disable scaling etc) in 
http://mxr.mozilla.org/mozilla-central/source/content/html/document/src/MediaDocument.cpp#243

http://junk.arandomurl.com/testvideo.html has none of the same bugs that the VideoDocument generate page does, despite being an identical dom

Currently debugging whether the viewport info is correctly picked up

Comment 12

[Dale Harvey (:daleharvey)]

Even more confusingly, if I build B2G manually and flash, the page is white (but behaves correctly) but if I flash the latest nightly build then the page is grey, picking up the css from /toolkit/themes/osx/global/media/TopLevelVideoDocument.css and doesnt behave (size) correctly

Comment 13

[Dale Harvey (:daleharvey)]

Quick update, as far as I can tell we are including the windows theme css in http://mxr.mozilla.org/mozilla-central/source/content/html/document/src/VideoDocument.cpp#77 

but not able to load the global styles for this page in http://mxr.mozilla.org/mozilla-central/source/content/html/document/src/VideoDocument.cpp#76

which would cause this bug

Comment 14

[Dale Harvey (:daleharvey)]

Confirmed that the problem is the global style is failing to be linked, the call to LinkStyleSheet is successful (chrome linked css does work as well) and the css is packaged in dist/bin/res so not exactly sure what is failing

Comment 15

[Kan-Ru Chen [:kanru] (UTC+9)]

dist/bin/res/TopLevel{Video,Image}Document.css are not included in the final omni.ja file. I'm looking for reasons.

Comment 16

[Kan-Ru Chen [:kanru] (UTC+9)]

Attachment: Patch for m-c

Comment 17

[Kan-Ru Chen [:kanru] (UTC+9)]

Attachment: Patch for b2g18

Comment 18

[Dylan Oliver [:doliver]]

kanru, are these patches ready for review?

Comment 19

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Comment on attachment 768231 [details] [diff] [review]
Patch for m-c

Review of attachment 768231 [details] [diff] [review]:
-----------------------------------------------------------------

I think technically this is build-system code that requires a build-system peer to review. But patches to this file seem to get reviews from all over.

Comment 20

[Kan-Ru Chen [:kanru] (UTC+9)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/a039e9463abe

Comment 21

[Kan-Ru Chen [:kanru] (UTC+9)]

https://hg.mozilla.org/releases/mozilla-b2g18/rev/d5039dfd3f2d

Comment 22

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/a039e9463abe