Last Comment Bug 883147 - Bookmark star icon missing for hidpi displays on OSX
: Bookmark star icon missing for hidpi displays on OSX
Status: RESOLVED FIXED
[Australis:M7]
: regression
Product: Firefox
Classification: Client Software
Component: Theme (show other bugs)
: Trunk
: x86 Mac OS X
-- normal (vote)
: Firefox 28
Assigned To: Mike Conley (:mconley)
:
: Dão Gottwald [:dao]
Mentors:
Depends on:
Blocks: australis-cust 856665
  Show dependency treegraph
 
Reported: 2013-06-14 07:13 PDT by Mike Conley (:mconley)
Modified: 2013-11-18 13:03 PST (History)
1 user (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
Patch v1 (917 bytes, patch)
2013-06-14 07:38 PDT, Mike Conley (:mconley)
gijskruitbosch+bugs: review+
Details | Diff | Splinter Review

Description User image Mike Conley (:mconley) 2013-06-14 07:13:10 PDT
I suspect this regressed after bug 856665 landed. Patch coming.
Comment 1 User image Mike Conley (:mconley) 2013-06-14 07:38:16 PDT
Created attachment 762681 [details] [diff] [review]
Patch v1

We just blindly doubled the coordinates for the bookmarks menu button, assuming that Toolbar@2x was the same as Toolbar...

Well, it's not. At least, not for now. The WebRTC button is missing from Toolbar@2x.

This'll all get sorted once bug 877335 lands. In the meantime, this is a stopgap fix.
Comment 2 User image :Gijs (away until Feb 27) 2013-06-14 07:50:05 PDT
Pushed, https://hg.mozilla.org/projects/ux/rev/0384f4c209f9
Comment 3 User image :Gijs (away until Feb 27) 2013-11-18 13:03:07 PST
https://hg.mozilla.org/mozilla-central/rev/0384f4c209f9

Note You need to log in before you can comment on or make changes to this bug.