Bookmark star icon missing for hidpi displays on OSX

RESOLVED FIXED in Firefox 28

Status

()

Firefox
Theme
RESOLVED FIXED
4 years ago
4 years ago

People

(Reporter: mconley, Assigned: mconley)

Tracking

(Blocks: 1 bug, {regression})

Trunk
Firefox 28
x86
Mac OS X
regression
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [Australis:M7])

Attachments

(1 attachment)

(Assignee)

Description

4 years ago
I suspect this regressed after bug 856665 landed. Patch coming.
(Assignee)

Comment 1

4 years ago
Created attachment 762681 [details] [diff] [review]
Patch v1

We just blindly doubled the coordinates for the bookmarks menu button, assuming that Toolbar@2x was the same as Toolbar...

Well, it's not. At least, not for now. The WebRTC button is missing from Toolbar@2x.

This'll all get sorted once bug 877335 lands. In the meantime, this is a stopgap fix.
Attachment #762681 - Flags: review?(gijskruitbosch+bugs)

Updated

4 years ago
Attachment #762681 - Flags: review?(gijskruitbosch+bugs) → review+

Comment 2

4 years ago
Pushed, https://hg.mozilla.org/projects/ux/rev/0384f4c209f9
Whiteboard: [Australis:M7] → [Australis:M7][fixed-in-ux]

Comment 3

4 years ago
https://hg.mozilla.org/mozilla-central/rev/0384f4c209f9
Status: NEW → RESOLVED
Last Resolved: 4 years ago
Resolution: --- → FIXED
Whiteboard: [Australis:M7][fixed-in-ux] → [Australis:M7]
Target Milestone: --- → Firefox 28
You need to log in before you can comment on or make changes to this bug.