Test for the playback rate reset (followup bug 825329)

ASSIGNED
Assigned to

Status

()

Core
Audio/Video: Playback
P2
normal
Rank:
15
ASSIGNED
5 years ago
a month ago

People

(Reporter: padenot, Assigned: padenot)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

(Assignee)

Description

5 years ago
(In reply to Paul Adenot (:padenot) from comment #12)
> Pushed without the test, too much people are complaining about this bug, and
> I have no time as per now to make the test pass on try. Leaving this open so
> I can push the test sometime.
> 
> https://hg.mozilla.org/integration/mozilla-inbound/rev/1bb461d484b2

This bug is about the test.
(Assignee)

Updated

5 years ago
No longer depends on: 825329
Component: Audio/Video → Audio/Video: Playback
(Assignee)

Comment 1

a year ago
JW, do you have a test that does something like:

> mediaElement.playbackRate = 2.0;
> ...wait a bit...
> mediaElement.playbackRate = 1.0;

and that checks that everything works as intended ?
Flags: needinfo?(jwwang)
Maybe dom/media/test/test_playback_rate.html is what you want.
Flags: needinfo?(jwwang)
(Assignee)

Comment 3

a year ago
Yeah I know I wrote it, but when I wrote it, I didn't include a test for this, but you've made quite a lot of fixes to this particular feature, so I was wondering if you remember adding a test for this?
Flags: needinfo?(jwwang)
No. I think we should add one. test_playback_rate.html only tests playbackRate changes from 1 to some other values but not the other way around. In fact, I would like to split test_playback_rate.html into more small tests. For now test_playback_rate.html involves several playbackRate changes during the test and sometimes it is hard to debug which session goes wrong.
Flags: needinfo?(jwwang)

Updated

a month ago
Rank: 15
Priority: -- → P2
You need to log in before you can comment on or make changes to this bug.