Closed Bug 883203 Opened 10 years ago Closed 10 years ago

On OS X, run all plugins OOP by default when in 32-bit mode (i386/x86)

Categories

(SeaMonkey :: Preferences, defect)

Product:
SeaMonkey
Component:
Preferences
Platform:
x86
macOS
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(seamonkey2.20 fixed, seamonkey2.21 fixed, seamonkey2.22 unaffected)

Status:
RESOLVED FIXED
Milestone:
seamonkey2.21
Tracking Flags:
Tracking Status
seamonkey2.20 --- fixed
seamonkey2.21 --- fixed
seamonkey2.22 --- unaffected

People

(Reporter: philip.chee, Assigned: philip.chee)

Details

Attachments

(1 file)

Patch v1.0
1.85 KB, patch
iannbugzilla
: review+
stefanh
: feedback+
neil
: approval-comm-aurora+
iannbugzilla
: approval-comm-beta+
Details | Diff | Splinter Review 
From Bug 863830 Comment 0:

> As a first step, let's make all plugins run OOP in 32-bit mode, without 
> exceptions, and see what happens.  This should happen first on trunk, and 
> should graduate to other branches as part of the normal, 6 week release cycle. 

> In other words, the progress of this change onto the branches shouldn't be 
> accelerated.

> If we find any 32-bit plugins that need to run in-process, we can consider 
> making exceptions for them.
Attached patch Patch v1.0 — — Splinter Review 
Need some feedback from someone on OS X hence Stefan.
Attachment #762826 - Flags: feedback?(stefanh)
Comment on attachment 762826 [details] [diff] [review]
Patch v1.0

Makes sense to me.
Attachment #762826 - Flags: feedback?(stefanh) → feedback+
> Makes sense to me.
Yes. But does it have the expected effect on OS X? I can't test obviously.
Flags: needinfo?(stefanh)
I can't test the patch since my build is a pure 64-bit, but with a nightly I can see that the Google Earth plugin runs its own process if I set the 'dom.ipc.plugins.enabled.i386' pref to true and restart in 32-bit mode.
Flags: needinfo?(stefanh)
Comment on attachment 762826 [details] [diff] [review]
Patch v1.0

OK, thanks Stefan. Over to IanN.
Attachment #762826 - Flags: review?(iann_bugzilla)
Attachment #762826 - Flags: review?(iann_bugzilla) → review+
Comment on attachment 762826 [details] [diff] [review]
Patch v1.0

[Approval Request Comment]
Regression caused by (bug #): N/A Referenced Firefox Bug 863830 landed on mozilla23
User impact if declined: 32bit plugins aren't run as OOP. Buggy plugins can crash SeaMonkey if they aren't run in a separate process.
Testing completed (on m-c, etc.):  Tested and baked on m-c since 2013-04-25
Risk to taking this patch (and alternatives if risky): low to none since:

Bug 863830 Comment 0:
> We've since dropped support for the QuickDraw drawing model (in FF 18) and
> the Carbon event model (in FF 19)

Any remaining 32bit plugins should be able to run OOP.

String changes made by this patch: None.
Attachment #762826 - Flags: approval-comm-aurora?
Pushed to comm-central:
http://hg.mozilla.org/comm-central/rev/d24d0ef7532c
a=Callek CLOSED TREE
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → seamonkey2.21
Attachment #762826 - Flags: approval-comm-aurora? → approval-comm-aurora+
> neil@parkwaycc.co.uk 2013-07-21 03:43:59 PDT
> Attachment #762826 [details] [diff] - Flags: approval-comm-aurora? → approval-comm-aurora+
This rode the trains and landed on aurora already:
https://hg.mozilla.org/releases/comm-aurora/rev/d24d0ef7532c
Comment on attachment 762826 [details] [diff] [review]
Patch v1.0

[Triage Comment]
a=me for comm-beta
Attachment #762826 - Flags: approval-comm-beta+
You need to log in before you can comment on or make changes to this bug.