883335 - Need to figure out UI for settings when volume can't be shared with PC

Status: RESOLVED WONTFIX

(Firefox OS Graveyard :: Gaia::Settings, defect)

Description

[Dave Hylands [:dhylands]]

Currently, when you enable USB Mass Storage in the Settings app, there are 2 reasons why the volume can fail to be shared with the PC.

In either of these scenarios, there is currently no user feedback, and the user won't know why the volume didn't appear in the PC.

One of the reasons that sharing can fail is if there is a volume lock. Currently, volume locks are obtained while storing an update to an sdcard, or while transferring a file to the sdcard via bluetooth. The current behaviour (at least with bug 876782) is that if a volume lock is held, then the Automounter puts the following message in logcat:

    UpdateState: Mounted volume XXX is locked, not sharing

With bug 876782 sharing can fail if there are any open files on the volume (perhaps the music player is currently playing a song). In this case, logs like the following will show up:

   The following files are open under '/mnt/sdcard'
     PID: 2697 file: '/mnt/sdcard/foo' app: '' comm: 'sh' exe: '/system/bin/mksh'
     PID: 2702 file: '/mnt/sdcard/foo' app: '' comm: 'cat' exe: '/system/bin/toolbox'
     PID: 3352 file: '/mnt/sdcard/Music/01_-_Love Who You Love.mp3' app: 'Music' comm: 'Music' exe: '/system/b2g/plugin-container'
   UpdateState: Mounted volume sdcard has open files, leaving

However, this is not really discoverable by the user. So I think we need some mechanism to communicate to the user that files are open, and perhaps a way to find out what files are open.

Comment 1

[Alex Keybl [:akeybl]]

Does this actually block bug 876782? This doesn't seem like a regression in 1.1. Please renominate with that justification, if it is a regression or a blocker for a leo+ bug.

Comment 2

[Dave Hylands [:dhylands]]

If its acceptable to have the USB Mass Storage appear to 'not work' while there are open files, then this bug doesn't need to block.

Comment 3

[Wayne Chang [:wchang]]

Triage- not blocking release for
- not a likely scenario for users to be transferring via BT and attempting to connect via UMS at the same time. Chances are the users would use the PC to do whatever transfer they wish to do.
- new strings are required if we take this to create a prompt to inform the user of the situation.

Comment 4

[Dave Hylands [:dhylands]]

BT isn't the only thing that can old files open. If you're playing Music or Watching a video, then these operations hold files open as well.

Comment 5

[Hema Koka [:hema]]

Blocks 912609 (For triage decisions see comments: https://bugzilla.mozilla.org/show_bug.cgi?id=912609#c10 and https://bugzilla.mozilla.org/show_bug.cgi?id=912609#c15)

Comment 6

[Jason Smith [:jsmith]]

I'm really confused by all of the threads on this, so I'm asking for QA Wanted to confirm the following:

On the latest 1.1 build on any shipping production device, is there a warning message that appears when you try to enable USB mass storage when you are playing a music file in the background?

Comment 7

[Dave Hylands [:dhylands]]

(In reply to Jason Smith [:jsmith] from comment #6)
> I'm really confused by all of the threads on this, so I'm asking for QA
> Wanted to confirm the following:
> 
> On the latest 1.1 build on any shipping production device, is there a
> warning message that appears when you try to enable USB mass storage when
> you are playing a music file in the background?

To the best of my knowledge, no release has ever included a warning message that appears when you are playing a music file.

The only warning that I'm aware of is one that shows up the very first time that you enable UMS (irrespective of whether music is playing or not).

My understanding of the various behaviours is:

In 1.1, If you enable UMS while music is playing, then UMS just appears to not work, until the music stops.

In pre-1.1, If you enable UMS while while music is playing, then the music app is immediatly killed, and UMS is enabled. Sometimes the mediaserver would also crash.

In recent 1,2, if you enable UMS while music is playing, then the music app exits (typically within a second) and UMS is enabled.

Comment 8

[Jason Smith [:jsmith]]

Okay. Moving to 1.3? then.

Comment 9

[Bruce Huang [:bhuang] (inactive)]

SystemPlatform triage: plus for 1.3

Comment 10

[Jason Smith [:jsmith]]

(In reply to Bruce Huang (:bhuang) from comment #9)
> SystemPlatform triage: plus for 1.3

This is not a committed feature for 1.3, so this should not block the release.

Comment 11

[Bruce Huang [:bhuang] (inactive)]

Adding to System-Platform backlog

Comment 12

[BMO Automation]

Firefox OS is not being worked on