bugzilla.mozilla.org has resumed normal operation. Attachments prior to 2014 will be unavailable for a few days. This is tracked in Bug 1475801.
Please report any other irregularities here.

Only use default facebook app id if is mozilla partner build

VERIFIED FIXED

Status

Firefox OS
Gaia::Contacts
VERIFIED FIXED
5 years ago
5 years ago

People

(Reporter: fabrice, Assigned: gasolin@mozilla.com)

Tracking

({regression, smoketest})

unspecified
All
Gonk (Firefox OS)
regression, smoketest
Dependency tree / graph

Firefox Tracking Flags

(blocking-b2g:tef+, b2g18 verified, b2g18-v1.0.1 affected, b2g-v1.1hd fixed)

Details

(Whiteboard: leorun4)

Attachments

(1 attachment, 1 obsolete attachment)

181 bytes, text/html
timdream
: review+
Details
Comment hidden (empty)
(Reporter)

Updated

5 years ago
OS: Linux → Gonk (Firefox OS)
Hardware: x86_64 → All
(Reporter)

Comment 1

5 years ago
Created attachment 762873 [details]
Link to the PR
Assignee: nobody → fabrice
Attachment #762873 - Flags: review?(timdream)

Updated

5 years ago
Duplicate of this bug: 883365
Regression from a tef+ blocker in bug 882363. If we don't take this on all branches, then we will be unable to test facebook imports in the Contacts app on any non-customized build.
blocking-b2g: --- → tef?
Keywords: regression, smoketest

Updated

5 years ago
Blocks: 882363

Updated

5 years ago
blocking-b2g: tef? → tef+
Attachment #762873 - Flags: review?(timdream) → review+
Actually, I wonder if we should enable Facebook import only for official build, or for all open source builds?
Chris, do you know the answer to comment 4?
Flags: needinfo?(clee)

Comment 6

5 years ago
(In reply to Jason Smith [:jsmith] from comment #3)
> Regression from a tef+ blocker in bug 882363. If we don't take this on all
> branches, then we will be unable to test facebook imports in the Contacts
> app on any non-customized build.

Note that this is tef+ only to ensure that local builds have working Facebook import. Kind of NPOTB
Whiteboard: [NPOTB]

Comment 7

5 years ago
(In reply to Tim Guan-tin Chien [:timdream] (MoCo-TPE) from comment #4)
> Actually, I wonder if we should enable Facebook import only for official
> build, or for all open source builds?

If QA can test on a nightly, and developers can test locally (when they need to) then I don't think we'll have a strong opinion here.
Assignee: fabrice → timdream

Comment 8

5 years ago
(Fabrice is out right now by the way, which is why I've reassigned)
(In reply to Alex Keybl [:akeybl] from comment #8)
> (Fabrice is out right now by the way, which is why I've reassigned)

I'll love to get comment 4 answered before landing the fix (or, taking over the bug)

Comment 10

5 years ago
I will check with our Legal team and respond back.  Thanks.
Flags: needinfo?(clee)
Sorry about keeping people in the dark. In another thread, Chris suggests
the API client_id shouldn't exist in open source build and it's OEM's
responsibility to test the build with the key they included.

I will go ahead and close that bug as invalid.
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → INVALID
That bug resolution isn't going to work. QA needs the ability to test Facebook import functionality on non-customized builds. TEF QA is the primary owner of testing this feature, but Mozilla QA often helps out with testing this feature as well. Without having a capability to this feature, we will not be able to investigate bugs that come in this area and conduct test runs until we have partner customized builds with the Facebook API key included. We need a solution here that allows testing of that functionality on a non-customized build. So I don't think that bug should be resolved invalid - we need an actual solution that allows testing on a non-customized build.
Status: RESOLVED → REOPENED
Resolution: INVALID → ---
Per reply from Chris, we would enable the key behind the official branding build flag, i.e. the key would exist in the public repo, but it would only be enabled when the branding is switched on.
Whiteboard: [NPOTB]
Attachment #762873 - Attachment is obsolete: true
(Assignee)

Comment 14

5 years ago
take it.
Assignee: timdream → gasolin
Summary: Update the default facebook app id → Only use default facebook app id if is mozilla partner build
(Assignee)

Comment 15

5 years ago
Created attachment 767630 [details]
pull request redirect to github

when set MOZILLA_OFFICIAL=1, it will take default facebook app id. 

If there's any customized json exist, overwrite by the customized json.
Attachment #767630 - Flags: review?(timdream)
Comment on attachment 767630 [details]
pull request redirect to github

We should re-organize application-data.js one day.
Attachment #767630 - Flags: review?(timdream) → review+
(Assignee)

Comment 17

5 years ago
merged in master-gaia be79ceb2b5d399087745a8af0da6a30d09d4d742
thanks!
Status: REOPENED → RESOLVED
Last Resolved: 5 years ago5 years ago
Resolution: --- → FIXED
(Assignee)

Updated

5 years ago
status-b2g18: --- → affected
status-b2g18-v1.0.1: --- → affected
status-b2g-v1.1hd: --- → affected

Comment 18

5 years ago
I've put a relevant comment on GH that you have not paid attention. Please check
(Assignee)

Comment 19

5 years ago
Hi Jose, 

tim has replied on GH. Add default id to communications_services.json does not fit the criteria of comment 13.
John - This a breaking a smoke test and blocking QA testing. Can you get this uplifted asap?
Flags: needinfo?(jhford)
[v1-train 4d6cbe4]

There are merge conflicts on v1.0.1
status-b2g18: affected → fixed
Flags: needinfo?(jhford) → needinfo?(gasolin)
v1.1.0hd: 4d6cbe49fdba32f72ec8bc6280e4782c250ab41e
status-b2g-v1.1hd: affected → fixed
(Assignee)

Comment 23

5 years ago
john, please uplift bug 883510 before apply this patch to v1.0.1
Flags: needinfo?(gasolin) → needinfo?(jhford)
Fred, the commit from 883510 does not apply cleanly to v1-train or v1.0.1.  I've flaged you and the bug assignee, but I just wanted to give you a heads up here as well that you're likely going to need to rework this patch as well.
Flags: needinfo?(jhford) → needinfo?(gasolin)

Comment 25

5 years ago
Verified - issue no longer reproduce on Leo Build ID: 20130627070213
Gecko: http://hg.mozilla.org/releases/mozilla-b2g18/rev/6a9ca50a313b
Gaia: fa3d64fad6f3b69be17ebbfdf4b406108afc99f4
Platform Version: 18.1
RIL Version: 01.01.00.019.138
Status: RESOLVED → VERIFIED
(Assignee)

Comment 26

5 years ago
replied in bug 883510 comment 24 ,
after experiment, I think bug 883344 looks fine if bug 883510 is uplifted.
Flags: needinfo?(gasolin)

Updated

5 years ago
Whiteboard: leorun4

Comment 27

5 years ago
I've filed a bug for the Keon Geeksphone - bug 891045

Is it fine if I ask Geeksphone to use MOZILLA_OFFICIAL=1?

Does any of you know how to talk to them? I've used their forums but they have not responded yet.

Updated

5 years ago
status-b2g18: fixed → verified
Attachment mime type: text/plain → text/x-github-pull-request
You need to log in before you can comment on or make changes to this bug.