883383 - Fix more static rooting analysis failures in SpiderMonkey

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect)

Description

[Terrence Cole [:terrence]]

Attachment: v0

This should be the last with the exception of one false positive with the exception of the unsafe-address-of hazards.

Comment 1

[Steve Fink [:sfink] [:s:]]

Comment on attachment 762921 [details] [diff] [review]
v0

Review of attachment 762921 [details] [diff] [review]:
-----------------------------------------------------------------

::: js/src/builtin/TestingFunctions.cpp
@@ +913,5 @@
>  {
>      Value thisv = UndefinedValue();
>  
> +    RootedValue rval(cx);
> +    if (!Invoke(cx, thisv, ObjectValue(*objectMetadataFunction), 0, NULL, rval.address())) {

I'll let you get away with this for now :) but it's about time for Invoke to take a MutableHandleValue. There are 45 callers that pass .address() right now, and less than a dozen that take something else.

Comment 2

[Terrence Cole [:terrence]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/ec253175bb51

Comment 3

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/ec253175bb51