Closed Bug 883397 Opened 11 years ago Closed 4 years ago

Determine if check for about:blank in CustomizeMode.exit is really necessary

Categories

(Firefox :: Toolbars and Customization, defect)

defect
Not set
normal
Points:
1

Tracking

()

RESOLVED FIXED
Firefox 74
Iteration:
74.1 - Jan 6 - Jan 19
Tracking Status
firefox74 --- fixed

People

(Reporter: mconley, Assigned: dao)

Details

Attachments

(1 file)

Gijs pointed this out in bug 881909 comment 15 - in browser/components/customizableui/CustomizeMode.jsm (exit function), we're checking the URL to see if it matches about:customizing before we decide whether or not to go back a page in history, or close the tab.

That check might not really be necessary.

about:customizing is gone after bug 1014185 but the check is still there for about:blank.

Summary: Determine if check for about:customizing in CustomizeMode.exit is really necessary → Determine if check for about:blank in CustomizeMode.exit is really necessary
Assignee: nobody → dao+bmo
Status: NEW → ASSIGNED
Iteration: --- → 74.1 - Jan 6 - Jan 19
Points: --- → 1
Hardware: x86_64 → All
Pushed by dgottwald@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/481808568735
Remove redundant about:blank check from CustomizeMode.exit. r=Gijs
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 74
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: