Allow deletion of news posts by default (with a prompt!)

RESOLVED FIXED in Thunderbird 24.0

Status

MailNews Core
Database
--
enhancement
RESOLVED FIXED
4 years ago
4 years ago

People

(Reporter: squib, Assigned: squib)

Tracking

unspecified
Thunderbird 24.0

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 2 obsolete attachments)

(Assignee)

Description

4 years ago
Created attachment 763063 [details] [diff] [review]
Patch

Thanks to jcranmer, we've had the ability to delete the local copies of news posts for some time. However, it's been locked behind a hidden pref. Now that we have a confirmation prompt when shift-deleting messages, we can expand that logic a bit to account for deleting news posts as well.

This means that, with the exception of "Junk", the buttons in the message header for news actually match those for mail!
Attachment #763063 - Flags: review?(Pidgeot18)
(Assignee)

Comment 1

4 years ago
Created attachment 763064 [details] [diff] [review]
Proper patch

Whoops, I accidentally posted an interdiff instead of the proper diff!
Attachment #763063 - Attachment is obsolete: true
Attachment #763063 - Flags: review?(Pidgeot18)
Attachment #763064 - Flags: review?(Pidgeot18)
(Assignee)

Comment 2

4 years ago
Just a note: this doesn't actually *require* any l10n changes (in fact, I'm not sure we even want the string I added), so we could theoretically land this during aurora.
Comment on attachment 763064 [details] [diff] [review]
Proper patch

Review of attachment 763064 [details] [diff] [review]:
-----------------------------------------------------------------

I don't think there's much of a difference to having the separate string for the "post" versus "message", considering that we don't use a lot of "post" terminology in mailnews.

Also, next time, please try to remember to use -p when making patches. :-)
Attachment #763064 - Flags: review?(Pidgeot18) → review+
(Assignee)

Comment 4

4 years ago
Created attachment 766378 [details] [diff] [review]
Remove new string

This removes the new string (but renames the old shift-delete one since the context changed). I'm posting this here instead of just pushing because the Seamonkey tree is closed.
Attachment #763064 - Attachment is obsolete: true
Attachment #766378 - Flags: review+
(Assignee)

Comment 5

4 years ago
Landed: https://hg.mozilla.org/comm-central/rev/0eca3fec431a
Status: ASSIGNED → RESOLVED
Last Resolved: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 24.0
You need to log in before you can comment on or make changes to this bug.