Closed Bug 883485 Opened 11 years ago Closed 11 years ago

Allow deletion of news posts by default (with a prompt!)


(MailNews Core :: Database, enhancement)

Not set


(Not tracked)

Thunderbird 24.0


(Reporter: squib, Assigned: squib)



(1 file, 2 obsolete files)

Attached patch Patch (obsolete) — Splinter Review
Thanks to jcranmer, we've had the ability to delete the local copies of news posts for some time. However, it's been locked behind a hidden pref. Now that we have a confirmation prompt when shift-deleting messages, we can expand that logic a bit to account for deleting news posts as well.

This means that, with the exception of "Junk", the buttons in the message header for news actually match those for mail!
Attachment #763063 - Flags: review?(Pidgeot18)
Attached patch Proper patch (obsolete) — Splinter Review
Whoops, I accidentally posted an interdiff instead of the proper diff!
Attachment #763063 - Attachment is obsolete: true
Attachment #763063 - Flags: review?(Pidgeot18)
Attachment #763064 - Flags: review?(Pidgeot18)
Just a note: this doesn't actually *require* any l10n changes (in fact, I'm not sure we even want the string I added), so we could theoretically land this during aurora.
Comment on attachment 763064 [details] [diff] [review]
Proper patch

Review of attachment 763064 [details] [diff] [review]:

I don't think there's much of a difference to having the separate string for the "post" versus "message", considering that we don't use a lot of "post" terminology in mailnews.

Also, next time, please try to remember to use -p when making patches. :-)
Attachment #763064 - Flags: review?(Pidgeot18) → review+
This removes the new string (but renames the old shift-delete one since the context changed). I'm posting this here instead of just pushing because the Seamonkey tree is closed.
Attachment #763064 - Attachment is obsolete: true
Attachment #766378 - Flags: review+
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 24.0
You need to log in before you can comment on or make changes to this bug.