Closed Bug 883501 Opened 11 years ago Closed 11 years ago

Fix -Wreorder warning in xpcom/base/nsConsoleMessage.cpp.

Categories

(DevTools :: Console, defect)

defect
Not set
minor

Tracking

(firefox23 unaffected, firefox24 fixed)

RESOLVED FIXED
Firefox 24
Tracking Status
firefox23 --- unaffected
firefox24 --- fixed

People

(Reporter: cpeterson, Assigned: cpeterson)

References

(Blocks 1 open bug)

Details

(Keywords: regression)

Attachments

(1 file)

This patch fixes the only -Wreorder warning I see when building with clang for OSX or gcc for Android. It was a regression from bug 859756. xpcom/base/nsConsoleMessage.cpp:17:8 [-Wreorder] field 'mMessage' will be initialized after field 'mTimeStamp'
Attachment #763075 - Flags: review?(mihai.sucan)
Comment on attachment 763075 [details] [diff] [review] fix-Wreorder-warning.patch Thanks! That's my bad... I didn't see the warning.
Attachment #763075 - Flags: review?(mihai.sucan) → review+
Blocks: buildwarning
Version: unspecified → Trunk
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 24
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: