Closed Bug 883672 Opened 7 years ago Closed 6 years ago

XULLinkAccessible should implement text interface similar to XULLabelAccessible

Categories

(Core :: Disability Access APIs, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla26

People

(Reporter: stefanh, Assigned: Six)

References

(Depends on 1 open bug, Blocks 1 open bug)

Details

(Keywords: access, Whiteboard: [mentor=surkov.alexander@gmail.com][lang=c++])

Attachments

(1 file, 2 obsolete files)

Spin-off from bug 857461, comment #25.
Inherit XULLinkAccessible from XULLabelAccessible
Blocks: texta11y
Keywords: access
Whiteboard: [mentor=surkov.alexander@gmail.com][lang=c++]
Is this that simple?
Assignee: nobody → six.dsn
Status: NEW → ASSIGNED
Attachment #778865 - Flags: review?(surkov.alexander)
Comment on attachment 778865 [details] [diff] [review]
Inherit  XULLinkAccessible from XULLabelAccessible

Review canceled, i will submit another patch soon
Attachment #778865 - Flags: review?(surkov.alexander)
The same patch but with the correct NS_IMPL_ISUPPORTS_INHERITED1
Attachment #778865 - Attachment is obsolete: true
Attachment #779322 - Flags: review?(surkov.alexander)
please add tests (see bug 396166), example can be:

<label id="linkLabelWithValue" value="Mozilla Foundation" class="text-link"
   href="http://www.mozilla.org/" />
Comment on attachment 779322 [details] [diff] [review]
Inherit XULLinkAccessible from XULLabelAccessible

canceling review, I hope to see next patch
Attachment #779322 - Flags: review?(surkov.alexander)
The same patch plus the modification on mochitest hyperlink/test_general.xul
i'm unable to find a solution the do the events test, so i'm desassigning from this bug.
i stay cc to see how it has been done finally.
Attachment #779322 - Attachment is obsolete: true
Attachment #790914 - Flags: review?(surkov.alexander)
Assignee: six.dsn → nobody
Comment on attachment 790914 [details] [diff] [review]
Inherit XULLinkAccessible from XULLabelAccessible

Review of attachment 790914 [details] [diff] [review]:
-----------------------------------------------------------------

I think comment #5 (a mochitest requirest) can be addressed as followup, please file a bug for that, otherwise it's fine, r=me, thanks!
Attachment #790914 - Flags: review?(surkov.alexander) → review+
Assignee: nobody → six.dsn
Depends on: 905776
Should anything more be done here before the patch can be landed?
Flags: needinfo?(surkov.alexander)
it's ready to go
Flags: needinfo?(surkov.alexander)
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/1d29b04fc7c3
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla26
You need to log in before you can comment on or make changes to this bug.