The default bug view has changed. See this FAQ.

XULLinkAccessible should implement text interface similar to XULLabelAccessible

RESOLVED FIXED in mozilla26

Status

()

Core
Disability Access APIs
RESOLVED FIXED
4 years ago
4 years ago

People

(Reporter: stefanh, Assigned: Six)

Tracking

(Depends on: 1 bug, Blocks: 1 bug, {access})

Trunk
mozilla26
access
Points:
---
Dependency tree / graph
Bug Flags:
in-testsuite +

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [mentor=surkov.alexander@gmail.com][lang=c++])

Attachments

(1 attachment, 2 obsolete attachments)

(Reporter)

Description

4 years ago
Spin-off from bug 857461, comment #25.

Comment 1

4 years ago
Inherit XULLinkAccessible from XULLabelAccessible
Blocks: 368895
Keywords: access
Whiteboard: [mentor=surkov.alexander@gmail.com][lang=c++]
(Assignee)

Comment 2

4 years ago
Created attachment 778865 [details] [diff] [review]
Inherit  XULLinkAccessible from XULLabelAccessible

Is this that simple?
Assignee: nobody → six.dsn
Status: NEW → ASSIGNED
Attachment #778865 - Flags: review?(surkov.alexander)
(Assignee)

Comment 3

4 years ago
Comment on attachment 778865 [details] [diff] [review]
Inherit  XULLinkAccessible from XULLabelAccessible

Review canceled, i will submit another patch soon
Attachment #778865 - Flags: review?(surkov.alexander)
(Assignee)

Comment 4

4 years ago
Created attachment 779322 [details] [diff] [review]
Inherit XULLinkAccessible from XULLabelAccessible

The same patch but with the correct NS_IMPL_ISUPPORTS_INHERITED1
Attachment #778865 - Attachment is obsolete: true
Attachment #779322 - Flags: review?(surkov.alexander)

Comment 5

4 years ago
please add tests (see bug 396166), example can be:

<label id="linkLabelWithValue" value="Mozilla Foundation" class="text-link"
   href="http://www.mozilla.org/" />

Comment 6

4 years ago
Comment on attachment 779322 [details] [diff] [review]
Inherit XULLinkAccessible from XULLabelAccessible

canceling review, I hope to see next patch
Attachment #779322 - Flags: review?(surkov.alexander)
(Assignee)

Comment 7

4 years ago
Created attachment 790914 [details] [diff] [review]
Inherit XULLinkAccessible from XULLabelAccessible

The same patch plus the modification on mochitest hyperlink/test_general.xul
i'm unable to find a solution the do the events test, so i'm desassigning from this bug.
i stay cc to see how it has been done finally.
Attachment #779322 - Attachment is obsolete: true
Attachment #790914 - Flags: review?(surkov.alexander)
(Assignee)

Updated

4 years ago
Assignee: six.dsn → nobody

Comment 8

4 years ago
Comment on attachment 790914 [details] [diff] [review]
Inherit XULLinkAccessible from XULLabelAccessible

Review of attachment 790914 [details] [diff] [review]:
-----------------------------------------------------------------

I think comment #5 (a mochitest requirest) can be addressed as followup, please file a bug for that, otherwise it's fine, r=me, thanks!
Attachment #790914 - Flags: review?(surkov.alexander) → review+
(Assignee)

Updated

4 years ago
Assignee: nobody → six.dsn
Depends on: 905776
(Reporter)

Comment 9

4 years ago
Should anything more be done here before the patch can be landed?
Flags: needinfo?(surkov.alexander)

Comment 10

4 years ago
it's ready to go
Flags: needinfo?(surkov.alexander)
Keywords: checkin-needed
https://hg.mozilla.org/integration/mozilla-inbound/rev/1d29b04fc7c3
Flags: in-testsuite+
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/1d29b04fc7c3
Status: ASSIGNED → RESOLVED
Last Resolved: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla26
You need to log in before you can comment on or make changes to this bug.