Closed
Bug 883672
Opened 12 years ago
Closed 12 years ago
XULLinkAccessible should implement text interface similar to XULLabelAccessible
Categories
(Core :: Disability Access APIs, defect)
Core
Disability Access APIs
Tracking
()
RESOLVED
FIXED
mozilla26
People
(Reporter: stefanh, Assigned: Six)
References
(Depends on 1 open bug, Blocks 1 open bug)
Details
(Keywords: access, Whiteboard: [mentor=surkov.alexander@gmail.com][lang=c++])
Attachments
(1 file, 2 obsolete files)
|
2.80 KB,
patch
|
surkov
:
review+
|
Details | Diff | Splinter Review |
Spin-off from bug 857461, comment #25.
|
||
Comment 1•12 years ago
|
||
Inherit XULLinkAccessible from XULLabelAccessible
|
Assignee | |
Comment 2•12 years ago
|
||
Is this that simple?
Assignee: nobody → six.dsn
Status: NEW → ASSIGNED
Attachment #778865 -
Flags: review?(surkov.alexander)
|
|
Assignee | |
Comment 3•12 years ago
|
||
Comment on attachment 778865 [details] [diff] [review]
Inherit XULLinkAccessible from XULLabelAccessible
Review canceled, i will submit another patch soon
Attachment #778865 -
Flags: review?(surkov.alexander)
|
|
Assignee | |
Comment 4•12 years ago
|
||
The same patch but with the correct NS_IMPL_ISUPPORTS_INHERITED1
Attachment #778865 -
Attachment is obsolete: true
Attachment #779322 -
Flags: review?(surkov.alexander)
|
|
||
Comment 5•12 years ago
|
||
please add tests (see bug 396166), example can be:
<label id="linkLabelWithValue" value="Mozilla Foundation" class="text-link"
href="http://www.mozilla.org/" />
|
|
||
Comment 6•12 years ago
|
||
Comment on attachment 779322 [details] [diff] [review]
Inherit XULLinkAccessible from XULLabelAccessible
canceling review, I hope to see next patch
Attachment #779322 -
Flags: review?(surkov.alexander)
|
|
Assignee | |
Comment 7•12 years ago
|
||
The same patch plus the modification on mochitest hyperlink/test_general.xul
i'm unable to find a solution the do the events test, so i'm desassigning from this bug.
i stay cc to see how it has been done finally.
Attachment #779322 -
Attachment is obsolete: true
Attachment #790914 -
Flags: review?(surkov.alexander)
|
|
Assignee | |
Updated•12 years ago
|
Assignee: six.dsn → nobody
|
|
||
Comment 8•12 years ago
|
||
Comment on attachment 790914 [details] [diff] [review]
Inherit XULLinkAccessible from XULLabelAccessible
Review of attachment 790914 [details] [diff] [review]:
-----------------------------------------------------------------
I think comment #5 (a mochitest requirest) can be addressed as followup, please file a bug for that, otherwise it's fine, r=me, thanks!
Attachment #790914 -
Flags: review?(surkov.alexander) → review+
|
Reporter | |
Comment 9•12 years ago
|
||
Should anything more be done here before the patch can be landed?
Flags: needinfo?(surkov.alexander)
|
|
||
Comment 10•12 years ago
|
||
it's ready to go
Flags: needinfo?(surkov.alexander)
Keywords: checkin-needed
|
||
Comment 11•12 years ago
|
||
Flags: in-testsuite+
Keywords: checkin-needed
|
|
||
Comment 12•12 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla26
You need to log in
before you can comment on or make changes to this bug.
Description
•