Last Comment Bug 883672 - XULLinkAccessible should implement text interface similar to XULLabelAccessible
: XULLinkAccessible should implement text interface similar to XULLabelAccessible
Status: RESOLVED FIXED
[mentor=surkov.alexander@gmail.com][l...
: access
Product: Core
Classification: Components
Component: Disability Access APIs (show other bugs)
: Trunk
: All All
-- normal (vote)
: mozilla26
Assigned To: Arnaud Sourioux [:Six]
:
: alexander :surkov
Mentors:
Depends on: 905776
Blocks: texta11y
  Show dependency treegraph
 
Reported: 2013-06-16 13:04 PDT by Stefan [:stefanh]
Modified: 2013-08-21 05:16 PDT (History)
2 users (show)
ryanvm: in‑testsuite+
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
Inherit XULLinkAccessible from XULLabelAccessible (1.72 KB, patch)
2013-07-20 11:05 PDT, Arnaud Sourioux [:Six]
no flags Details | Diff | Splinter Review
Inherit XULLinkAccessible from XULLabelAccessible (1.84 KB, patch)
2013-07-22 12:07 PDT, Arnaud Sourioux [:Six]
no flags Details | Diff | Splinter Review
Inherit XULLinkAccessible from XULLabelAccessible (2.80 KB, patch)
2013-08-15 12:43 PDT, Arnaud Sourioux [:Six]
surkov.alexander: review+
Details | Diff | Splinter Review

Description User image Stefan [:stefanh] 2013-06-16 13:04:14 PDT
Spin-off from bug 857461, comment #25.
Comment 1 User image alexander :surkov 2013-06-16 18:23:50 PDT
Inherit XULLinkAccessible from XULLabelAccessible
Comment 2 User image Arnaud Sourioux [:Six] 2013-07-20 11:05:40 PDT
Created attachment 778865 [details] [diff] [review]
Inherit  XULLinkAccessible from XULLabelAccessible

Is this that simple?
Comment 3 User image Arnaud Sourioux [:Six] 2013-07-21 12:27:27 PDT
Comment on attachment 778865 [details] [diff] [review]
Inherit  XULLinkAccessible from XULLabelAccessible

Review canceled, i will submit another patch soon
Comment 4 User image Arnaud Sourioux [:Six] 2013-07-22 12:07:25 PDT
Created attachment 779322 [details] [diff] [review]
Inherit XULLinkAccessible from XULLabelAccessible

The same patch but with the correct NS_IMPL_ISUPPORTS_INHERITED1
Comment 5 User image alexander :surkov 2013-07-22 13:23:13 PDT
please add tests (see bug 396166), example can be:

<label id="linkLabelWithValue" value="Mozilla Foundation" class="text-link"
   href="http://www.mozilla.org/" />
Comment 6 User image alexander :surkov 2013-08-06 06:27:57 PDT
Comment on attachment 779322 [details] [diff] [review]
Inherit XULLinkAccessible from XULLabelAccessible

canceling review, I hope to see next patch
Comment 7 User image Arnaud Sourioux [:Six] 2013-08-15 12:43:01 PDT
Created attachment 790914 [details] [diff] [review]
Inherit XULLinkAccessible from XULLabelAccessible

The same patch plus the modification on mochitest hyperlink/test_general.xul
i'm unable to find a solution the do the events test, so i'm desassigning from this bug.
i stay cc to see how it has been done finally.
Comment 8 User image alexander :surkov 2013-08-15 12:55:02 PDT
Comment on attachment 790914 [details] [diff] [review]
Inherit XULLinkAccessible from XULLabelAccessible

Review of attachment 790914 [details] [diff] [review]:
-----------------------------------------------------------------

I think comment #5 (a mochitest requirest) can be addressed as followup, please file a bug for that, otherwise it's fine, r=me, thanks!
Comment 9 User image Stefan [:stefanh] 2013-08-20 13:14:59 PDT
Should anything more be done here before the patch can be landed?
Comment 10 User image alexander :surkov 2013-08-20 13:15:53 PDT
it's ready to go
Comment 11 User image Ryan VanderMeulen [:RyanVM] 2013-08-20 13:47:57 PDT
https://hg.mozilla.org/integration/mozilla-inbound/rev/1d29b04fc7c3
Comment 12 User image Ed Morley [:emorley] 2013-08-21 05:16:53 PDT
https://hg.mozilla.org/mozilla-central/rev/1d29b04fc7c3

Note You need to log in before you can comment on or make changes to this bug.