Closed Bug 883683 Opened 12 years ago Closed 12 years ago

Leak with DOM promises

Categories

(Core :: DOM: Core & HTML, defect)

Product:
Core
Component:
DOM: Core & HTML
Platform:
x86_64
macOS
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla25

People

(Reporter: jruderman, Assigned: baku)

References

(Blocks 1 open bug)

Details

(Keywords: memory-leak, testcase, Whiteboard: [MemShrink:P2])

Attachments

(1 file, 4 obsolete files)

patch
7.34 KB, patch
Details | Diff | Splinter Review
Attached file testcase (obsolete) —
Running with XPCOM_MEM_LEAK_LOG=2 shows this leaking nsDocument.
Attached patch patch (obsolete) — — Splinter Review
Attachment #763418 - Flags: review?(bzbarsky)
Comment on attachment 763418 [details] [diff] [review] patch Why would this fix the leak, exactly? >@@ -145,16 +159,18 @@ Promise::Fulfill(const GlobalObject& aGl >@@ -164,16 +180,18 @@ Promise::Resolve(const GlobalObject& aGl >@@ -183,16 +201,18 @@ Promise::Reject(const GlobalObject& aGlo Why would aCx and aValue be in different compartments here? They shouldn't be.
Attached patch patch (obsolete) — — Splinter Review
https://tbpl.mozilla.org/?tree=Try&rev=7fb3b9f1afdf
Attachment #763418 - Attachment is obsolete: true
Attachment #763418 - Flags: review?(bzbarsky)
Attachment #763636 - Flags: review?(bzbarsky)
Comment on attachment 763636 [details] [diff] [review] patch r=me
Attachment #763636 - Flags: review?(bzbarsky) → review+
Assignee: nobody → amarchesini
Blocks: 885333
Is this ready to land?
Whiteboard: [MemShrink] → [MemShrink:P2]
I rewrote the patch for Future instead Promise. The renaming will take a while before landing. https://tbpl.mozilla.org/?tree=Try&rev=143954d82cd7
Attached patch patch (obsolete) — — Splinter Review
Attachment #763293 - Attachment is obsolete: true
Attachment #763636 - Attachment is obsolete: true
Attached patch patch — — Splinter Review
Attachment #767688 - Attachment is obsolete: true
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/db69e91e2624
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla25
Shouldn't this be uplifted? IIRC, Promises landed in Fx 24.
Blocks: 887687
The original testcase still leaks for me. Filed bug 887687.
Request tracking for Fx 24, see Comment 12.
tracking-firefox24: --- → ?
(In reply to Florian Bender from comment #14) > Request tracking for Fx 24, see Comment 12. No need to track here,but an approval nomination with user impact and risk analysis should be enough to request uplift.
tracking-firefox24: ? → ---
Component: DOM → DOM: Core & HTML
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: