Closed
Bug 883683
Opened 11 years ago
Closed 11 years ago
Leak with DOM promises
Categories
(Core :: DOM: Core & HTML, defect)
Tracking
()
RESOLVED
FIXED
mozilla25
People
(Reporter: jruderman, Assigned: baku)
References
(Blocks 1 open bug)
Details
(Keywords: memory-leak, testcase, Whiteboard: [MemShrink:P2])
Attachments
(1 file, 4 obsolete files)
7.34 KB,
patch
|
Details | Diff | Splinter Review |
Running with XPCOM_MEM_LEAK_LOG=2 shows this leaking nsDocument.
Comment 2•11 years ago
|
||
Comment on attachment 763418 [details] [diff] [review] patch Why would this fix the leak, exactly? >@@ -145,16 +159,18 @@ Promise::Fulfill(const GlobalObject& aGl >@@ -164,16 +180,18 @@ Promise::Resolve(const GlobalObject& aGl >@@ -183,16 +201,18 @@ Promise::Reject(const GlobalObject& aGlo Why would aCx and aValue be in different compartments here? They shouldn't be.
Assignee | ||
Comment 3•11 years ago
|
||
https://tbpl.mozilla.org/?tree=Try&rev=7fb3b9f1afdf
Attachment #763418 -
Attachment is obsolete: true
Attachment #763418 -
Flags: review?(bzbarsky)
Attachment #763636 -
Flags: review?(bzbarsky)
Comment 4•11 years ago
|
||
Comment on attachment 763636 [details] [diff] [review] patch r=me
Attachment #763636 -
Flags: review?(bzbarsky) → review+
Assignee | ||
Updated•11 years ago
|
Assignee: nobody → amarchesini
Updated•11 years ago
|
Whiteboard: [MemShrink] → [MemShrink:P2]
Assignee | ||
Comment 6•11 years ago
|
||
I rewrote the patch for Future instead Promise. The renaming will take a while before landing. https://tbpl.mozilla.org/?tree=Try&rev=143954d82cd7
Assignee | ||
Comment 7•11 years ago
|
||
Attachment #763293 -
Attachment is obsolete: true
Attachment #763636 -
Attachment is obsolete: true
Assignee | ||
Updated•11 years ago
|
Keywords: checkin-needed
Comment 10•11 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/db69e91e2624
Flags: in-testsuite+
Keywords: checkin-needed
Comment 11•11 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/db69e91e2624
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla25
Comment 15•11 years ago
|
||
(In reply to Florian Bender from comment #14) > Request tracking for Fx 24, see Comment 12. No need to track here,but an approval nomination with user impact and risk analysis should be enough to request uplift.
tracking-firefox24:
? → ---
Updated•6 years ago
|
Component: DOM → DOM: Core & HTML
You need to log in
before you can comment on or make changes to this bug.
Description
•