88377 - table properties help button not placed correctly on Mac

Status: NEW

(SeaMonkey :: Composer, defect)

Description

[Kathleen :Brade]

All of Composer's dialogs which are spec'd to have a help button are done except 
the Table Properties dialog.  This one hasn't been completed yet because it has 
an Apply button which is going to make it a little different from the others.

I am anticipating this problem: the Apply button string is currently in a dtd 
file.  However, we'll need to move it to a properties file to set that string on 
the button in the overlay.

Comment 1

[msanz]

UI change approved

Comment 2

[sujay]

Also what about named anchor props and h. line props? these don't have Help
buttons either.

also page colors and background & page title and props.

Comment 3

[Kathleen :Brade]

in the specification from techPubs, those dialogs do not have help buttons

Comment 4

[Kathleen :Brade]

Attachment: patch for adding help button (compatible with apply button)

Comment 5

[Kathleen :Brade]

The above patch works and keeps the buttons in the proper order.
The only problem I see is that the buttons aren't right aligned (OK/Cancel).  I
can't seem to get them right aligned (even without an apply button).  Perhaps
it's a problem with this dialog having tabs?

Comment 6

[rubydoo123]

reviewed and approved

Comment 7

[Simon Fraser [no longer active]]

> reviewed and approved
What does this mean? The patch has not had code review, so "reviewed" is 
confusing.

Comment 8

[rubydoo123]

that is what I put in the bug so I know I am the one who entered the nsBranch
keyword, and it denotes that I have reviewed the bug and understand that it is
low risk, high return fix; and that I have approved it to be checked in to the
trunk and the branch

Comment 9

[Michele Carlson]

Can you please get the new UI checked in by 7/6? It would help Localization out
tremendously. thanks

Comment 10

[Charles Manske]

r=cmanske, with small change to keep the "<spring flex="1">" so buttons are
right-aligned. New patch to be added soon.

Comment 11

[Charles Manske]

Attachment: Updated patch: Keep '<spring flex="1"/>' so button alignment is correct

Comment 12

[Charles Manske]

Patch is tested: Apply works fine, Help button works great.

Comment 13

[Simon Fraser [no longer active]]

This needs testing on Mac too, since the button alignment is different.

Comment 14

[Simon Fraser [no longer active]]

I tested the patch. It's not ideal, but it's acceptable. With the patch, the 
button layout is:

                     [Help]  [Apply] [Cancel] [OK]

and it should be

  [Help]                     [Apply] [Cancel] [OK]

so sr=sfraser

Comment 15

[Charles Manske]

Oh, that explains why Kathy didn't include the <spring/>. But it seems you
agree that having most buttons in the right place seems better than left-aligning
everything, which is wrong for both Mac and Windows. With my patch, it is 100%
correct for Windows, and mostly correct for Mac.

Comment 16

[Charles Manske]

Checked into trunk.

Comment 17

[rubydoo123]

bae

Comment 18

[Charles Manske]

Attachment: Fixes button alignments in platform XUL

Comment 19

[Charles Manske]

My patch on 7/09 allows us to remove the "<spring flex="1"/>" from Composer's
EdTableProps.xul file. Thus we really should use that patch and the original
patch from Kathy on 6/29/01 11:25 to fix this bug.
This should fix button locations in all platforms.
I believe we should add the 'flex="1"' to *all* the "box" elements for all global
overlay button includes, but in the interest of minimum risk, I'm suggesting the
change only for the boxes used for the new Help buttons for now.

Comment 20

[rubydoo123]

using trunk build from 7/9 and testing on win98, this works fine
asking QA to test on mac and linux

Comment 21

[rubydoo123]

looks good on linux, akkana tested on current trunk build, and looks good on
mac, simon checked it out there.

per conversation with selmer, adding PDT+, removing vtrunk

Comment 22

[Kathleen :Brade]

Patch #2 was checked into the branch.
In my build, I noticed a problem with the 3rd patch above so I did not check that 
in.

I am removing keywords and leaving this bug open to deal with the button layout 
on Mac which is currently incorrect.

Set to milestone 1.0

Comment 23

[Syd Logan]

spam composer change

Comment 24

[Asa Dotzler [:asa]]

Bugs targeted at mozilla1.0 without the mozilla1.0 keyword moved to mozilla1.0.1 
(you can query for this string to delete spam or retrieve the list of bugs I've 
moved)

Comment 25

[rubydoo123]

removing myself from the cc list

Comment 26

[Kathleen :Brade]

-->cmanske

Comment 27

[Charles Manske]

The platform-specific buttons in the "Fixes button alignments in platform XUL"
patch are deprecated in favor of using the <dialog> element in dialogs instead
of <window>. The fix for bug 135945 contains that conversion and thus fixes this
bug as well.
I'm not sure if there's any point in applying that third patch.
Joe, Blake: Is anyone using that code anymore?

Comment 28

[Charles Manske]

This problems should no longer be visible since table dialog was changed by
fixing bug 135945.
Does anyone think we should bother with changes to the old global XUL in 
patches for this bug?

Comment 29

[Kathleen :Brade]

Clarifying what this problem is now:

The help button is now correctly located but the apply button is not.  
It currently looks like this:
  [Help] [Apply]                     [Cancel] [OK]


See comment 14 -- it should be:
  [Help]                     [Apply] [Cancel] [OK]

Comment 30

[Charles Manske]

Ok. That would be and XPFE or themes bug. I'll look into it.

Comment 31

[Charles Manske]

Attachment: patch for mac

Simply move the spacer to put space after "Help" button.

Comment 32

[Kathleen :Brade]

Comment on attachment 82286 [details] [diff] [review]
patch for mac

This patch will fix this bug but it is unacceptable because the
Save/Don'tSave/Cancel dialog won't lay out properly (the Don't Save button will
be too close to the other two bugs)

Comment 33

[Charles Manske]

Taking off adt radar. We'll work on this later

Comment 34

[Syd Logan]

nsbeta1- per buffy traige

Comment 35

[Serge Gautherie (:sgautherie)]

Charles,
Are you still working on this ?