Closed Bug 883781 Opened 7 years ago Closed 7 years ago

[Music] Shuffle Icon always being disabled from playlist->shuffle all ...

Categories

(Firefox OS Graveyard :: Gaia::Music, defect, P1)

ARM
Gonk (Firefox OS)

Tracking

(blocking-b2g:leo+, b2g18 fixed, b2g-v1.1hd fixed)

RESOLVED FIXED
1.1 QE3 (26jun)
blocking-b2g leo+
Tracking Status
b2g18 --- fixed
b2g-v1.1hd --- fixed

People

(Reporter: leo.bugzilla.gaia, Assigned: dkuo)

Details

(Keywords: regression, Whiteboard: [TD-45943])

Attachments

(3 files, 1 obsolete file)

[Music] Shuffle Icon always being disabled from playlist->shuffle all ...

1. Title : If a song is selected to play through "music player-> playlist -> shuffle all" , shuffle icon is always disabled
2. Precondition : Have couple of song on the device
3. Tester's Action : 1. Launch Music player.
                     2. Goto Playlist, select shuffle all
                     3. Music starts playing, but the shuffle all icon is disabled
4. Detailed Symptom (ENG.) : when music is selected to play through playlist->shuffle all, the shuffle icon should be active/enabled

5. Expected : Shuffle icon should be active or enabled, When a song is made to play through, music player->playlist->shuffle all
6.Reproducibility: Y
1)Frequency Rate : 100%
7.Gaia Master/v1-train : Reproduced
8.Gaia Revision: 032bcd8fb6eca83f701768d1ea123cc81623a6f6
9.Personal email id:   parthasarathy03210@gmail.com
blocking-b2g: --- → leo+
Whiteboard: [TD-45943]
I haven't check it yet but this should be a regression.
Assignee: nobody → dkuo
Keywords: regression
Priority: -- → P1
Attached video Video log attached
When user selects playlist -> shuffle all option..

When music starts playing, the shuffle icon is in inactive state.

refer video log
Hi, This is not reproducible anymore after AU131 applied on Leo.
AU131 corresponds to the Mozilla build ID: 20130616070209.
So, I think we can make this Resolved now.
Jinho, I think this is a gaia issue and I can reproduce it 100%, does AU131 mean some gecko patch?
(In reply to Leo from comment #2)
> Created attachment 764567 [details]
> Video log attached
> 
> When user selects playlist -> shuffle all option..
> 
> When music starts playing, the shuffle icon is in inactive state.
> 
> refer video log

I think I'm reproducing this on a one or two weeks old master on Inari. Upgrading to ensure reproductibility.
I'm reproducing on Inari with gaia master
Looks like there's a race condition that sets it and then that removes it.
Please find attached a link to the github pull request https://github.com/mozilla-b2g/gaia/pull/10609 which solves the race condition.

And thanks to vivien for the help :)
Attachment #767246 - Flags: review?(dkuo)
Alexandre, after reviewed your patch I found there might be a potential issue if asyncStorage fails, and here is my revised patch which base on attachment 767246 [details] [diff] [review], please take a look and let's discuss on irc.
Comment on attachment 767246 [details] [diff] [review]
Ensuring that setOptions() and click event do not race

Update: Alexandre's and my patches are combined into one so I shouldn't review my own patch, and I have discussed this issue with Rudy so he is kind of familiar with it and able to review it, Rudy, would you please review it? thanks.
Attachment #767246 - Flags: review?(dkuo) → review?(rlu)
Corrected the link to github pullrequest
Attachment #767246 - Attachment is obsolete: true
Attachment #767246 - Flags: review?(rlu)
Attachment #767673 - Flags: review?(rlu)
Comment on attachment 767673 [details]
Ensuring that setOptions() and click event do not race

r=me.

Dominic, gerard-majax,

Thanks for your work.
Attachment #767673 - Flags: review?(rlu) → review+
Thanks Rudy!

Landed on master: 128024f0923bfa39fe626f55d4f464be8c9557fc
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Uplifted 128024f0923bfa39fe626f55d4f464be8c9557fc to:
v1-train: f4dd890b2bdd35963e3b21b14364e70760de63f6
v1.1.0hd: f4dd890b2bdd35963e3b21b14364e70760de63f6
You need to log in before you can comment on or make changes to this bug.