883781 - [Music] Shuffle Icon always being disabled from playlist->shuffle all ...

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Music, defect, P1)

Description

[Leo]

[Music] Shuffle Icon always being disabled from playlist->shuffle all ...

1. Title : If a song is selected to play through "music player-> playlist -> shuffle all" , shuffle icon is always disabled
2. Precondition : Have couple of song on the device
3. Tester's Action : 1. Launch Music player.
                     2. Goto Playlist, select shuffle all
                     3. Music starts playing, but the shuffle all icon is disabled
4. Detailed Symptom (ENG.) : when music is selected to play through playlist->shuffle all, the shuffle icon should be active/enabled

5. Expected : Shuffle icon should be active or enabled, When a song is made to play through, music player->playlist->shuffle all
6.Reproducibility: Y
1)Frequency Rate : 100%
7.Gaia Master/v1-train : Reproduced
8.Gaia Revision: 032bcd8fb6eca83f701768d1ea123cc81623a6f6
9.Personal email id:   [e-mail]

Comment 1

[Dominic Kuo [:dkuo]]

I haven't check it yet but this should be a regression.

Comment 2

[Leo]

Attachment: Video log attached

When user selects playlist -> shuffle all option..

When music starts playing, the shuffle icon is in inactive state.

refer video log

Comment 3

[Jinho Hwang [:jeffhwang]]

Hi, This is not reproducible anymore after AU131 applied on Leo.
AU131 corresponds to the Mozilla build ID: 20130616070209.
So, I think we can make this Resolved now.

Comment 4

[Dominic Kuo [:dkuo]]

Jinho, I think this is a gaia issue and I can reproduce it 100%, does AU131 mean some gecko patch?

Comment 5

[:gerard-majax]

(In reply to Leo from comment #2)
> Created attachment 764567 [details]
> Video log attached
> 
> When user selects playlist -> shuffle all option..
> 
> When music starts playing, the shuffle icon is in inactive state.
> 
> refer video log

I think I'm reproducing this on a one or two weeks old master on Inari. Upgrading to ensure reproductibility.

Comment 6

[:gerard-majax]

I'm reproducing on Inari with gaia master

Comment 7

[:gerard-majax]

Looks like there's a race condition that sets it and then that removes it.

Comment 8

[:gerard-majax]

Attachment: Ensuring that setOptions() and click event do not race

Please find attached a link to the github pull request https://github.com/mozilla-b2g/gaia/pull/10609 which solves the race condition.

And thanks to vivien for the help :)

Comment 9

[Dominic Kuo [:dkuo]]

Attachment: get the player settings before entering the player

Alexandre, after reviewed your patch I found there might be a potential issue if asyncStorage fails, and here is my revised patch which base on attachment 767246 [details] [diff] [review], please take a look and let's discuss on irc.

Comment 10

[Dominic Kuo [:dkuo]]

Comment on attachment 767246 [details] [diff] [review]
Ensuring that setOptions() and click event do not race

Update: Alexandre's and my patches are combined into one so I shouldn't review my own patch, and I have discussed this issue with Rudy so he is kind of familiar with it and able to review it, Rudy, would you please review it? thanks.

Comment 11

[:gerard-majax]

Attachment: Ensuring that setOptions() and click event do not race

Corrected the link to github pullrequest

Comment 12

[Rudy Lu [:rudyl] (inactive after 2015/7/3)]

Comment on attachment 767673 [details]
Ensuring that setOptions() and click event do not race

r=me.

Dominic, gerard-majax,

Thanks for your work.

Comment 13

[Dominic Kuo [:dkuo]]

Thanks Rudy!

Landed on master: 128024f0923bfa39fe626f55d4f464be8c9557fc

Comment 14

[Gareth Aye [:gaye] (back from PTO)]

Uplifted 128024f0923bfa39fe626f55d4f464be8c9557fc to:
v1-train: f4dd890b2bdd35963e3b21b14364e70760de63f6

Comment 15

[John Ford [:jhford] CET/CEST Berlin Time]

v1.1.0hd: f4dd890b2bdd35963e3b21b14364e70760de63f6