883816 - [Cost Control] Usage Widget does not localize strings when changing language

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Cost Control, defect, P2)

Description

[Leo]

1. Title : Usage Widget "No SIM inserted" and the next line is not updated according to the language change.
2. Precondition : No SIM->Usage utility tray
3. Tester's Action : Change the language to some other language and check the Usage widget.The "No SIM inserted" and the down line is not updated to the current language.(After rebooting the device it works properly)
4. Detailed Symptom (ENG.) :It should change to current device language.
6.Reproducibility: Y
1)Frequency Rate : 100%\
7.Gaia Master/v1-train : Reproduced
8.Gaia Revision: 0c836be7f24693b74ad7fd21c8153824f1c7f548
9.Personal email id: [e-mail]

Comment 1

[Leo]

Attachment: Screenshot attached.

Comment 2

[Leo]

Attachment: SIM Lock Screenshot attached.

Comment 3

[Salvador de la Puente González [:salva]]

it seems we are missing some l10n strings.

Comment 4

[Axel Hecht [:Pike]]

Yes. Localizations are not complete, as mentioned in many other bugs.

Comment 5

[Leo]

Hi Salva,

This issue contains 2 types of errors.

1.With "Locked SIM" the L10n problem.
2.With "NO SIM" case the localization is not happend because even though the corresponding L10n is present.

Please find the STR for "NO SIM case"
1.Open Usage widget without SIM in English language.
2.And change the language of the device to spanish/Brazil
3.Open Usage widget and check the language.

Comment 6

[Salvador de la Puente González [:salva]]

Hello

(In reply to Leo from comment #5)
> Hi Salva,
> 
> This issue contains 2 types of errors.
> 
> 1.With "Locked SIM" the L10n problem.
> 2.With "NO SIM" case the localization is not happend because even though the
> corresponding L10n is present.

Ok. I checked this is a l10n problem about missing strings.

> 
> Please find the STR for "NO SIM case"
> 1.Open Usage widget without SIM in English language.
> 2.And change the language of the device to spanish/Brazil
> 3.Open Usage widget and check the language.

This other is a l10n problem about have not included proper l10n ids.

Let's split into 2 different bugs. I'm rewording this to reflect the second problem.

Comment 7

[Salvador de la Puente González [:salva]]

Ok, I created bug 884216 for the missing l10n strings problem.

Comment 8

[Salvador de la Puente González [:salva]]

Attachment: Now localizing HTML entities properly

Comment 9

[Francisco Jordano [:arcturus] [:francisco]]

Comment on attachment 765823 [details]
Now localizing HTML entities properly

Tested on the phone working perfectly.

Tiny comment on github, but r+ to the solution, pretty clean.

Thanks!

Comment 10

[Salvador de la Puente González [:salva]]

Master: 8edb0fa138a78676aed18d9492abb4f47d0bc069

Comment 11

[John Ford [:jhford] CET/CEST Berlin Time]

Uplifted 8edb0fa138a78676aed18d9492abb4f47d0bc069 to:
v1-train: 176825629d26977d34b7bf9f9d6ffce59cf9854d

Comment 12

[John Ford [:jhford] CET/CEST Berlin Time]

1.1hd: 176825629d26977d34b7bf9f9d6ffce59cf9854d