Closed
Bug 883897
Opened 12 years ago
Closed 12 years ago
[homepage] change the link to mozilla.org changing to https://www-dev.allizom.org/firefox/whatsnew
Categories
(Webtools Graveyard :: Elmo, defect, P3)
Webtools Graveyard
Elmo
Tracking
(Not tracked)
RESOLVED
FIXED
3.3
People
(Reporter: arky, Assigned: adrian)
References
()
Details
Attachments
(1 file)
1006 bytes,
patch
|
Pike
:
review+
|
Details | Diff | Splinter Review |
The web parts staging site link on team pages points to en-US
Testcase:
1. Go to German team page: https://l10n.mozilla.org/teams/de
2. Scroll and click on the "current status on the team's staging site." hyperlink in web dashboard section.
3. It will take you https://www-dev.allizom.org/en-US/ instead.
Comment 1•12 years ago
|
||
It links to https://www-dev.allizom.org/de/, but as the home page of mozilla.org isn't localized, that redirects to en-US.
No idea if there's a good link that resolves for all localizations.
Comment 2•12 years ago
|
||
This one maps to all locales activated:
https://www-dev.allizom.org/firefox/whatsnew
Comment 3•12 years ago
|
||
'k, let's use that then.
OS: Linux → All
Priority: -- → P3
Hardware: x86_64 → All
Summary: Staging site link is broken → [homepage] change the link to mozilla.org changing to https://www-dev.allizom.org/firefox/whatsnew
Assignee | ||
Updated•12 years ago
|
Assignee: nobody → adrian
Assignee | ||
Comment 4•12 years ago
|
||
Attachment #775957 -
Flags: review?(l10n)
Comment 5•12 years ago
|
||
Comment on attachment 775957 [details] [diff] [review]
Updated link to the team staging site
Review of attachment 775957 [details] [diff] [review]:
-----------------------------------------------------------------
r=me.
A few notes on version control patterns in elmo, as this is your first patch, and elmo is a tad different to other webdev pieces, AFAIK:
We use gitflow, without merge commits. So you want to rebase/ff-merge to the develop branch.
Commit messages follow the form "bug ...., some comment, r=whoever". multiline commit messages are OK, but the first line should follow this pattern.
Bugs are fixed when landed on develop, and we set the target milestone to year.quarter. Right now, that's 3.3.
("fixes bug ..." would be OK, but as you should touch the bug afterwards anyway, there's not much win)
If you have questions, feel free to poke me on irc.
Attachment #775957 -
Flags: review?(l10n) → review+
Comment 6•12 years ago
|
||
Commit pushed to develop at https://github.com/mozilla/elmo
https://github.com/mozilla/elmo/commit/6184c842fbb9204d09a605ed82afd399fa378908
bug 883897, updated link to the team staging site, r=Pike
Assignee | ||
Updated•12 years ago
|
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Target Milestone: --- → 3.3
Updated•5 years ago
|
Product: Webtools → Webtools Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•