[ms] Add locale code to websites and product-details

RESOLVED FIXED

Status

RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: arky, Unassigned)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(2 attachments)

(Reporter)

Description

5 years ago
Please add 'Malay(ms)' to *.mozilla.org websites and product-details libraries.
Any updates about this?
Flags: needinfo?(hitmanarky)
(Reporter)

Comment 2

5 years ago
Can you please make sure all critical web parts are complete. http://mozilla.locamotion.org/ms/mozilla_lang/goals
Flags: needinfo?(hitmanarky)
Arky, we just done today (l10n sprint session with helped by Fahmi, Shakir & Amirol) for all strings in Web Part. 

You may check here, http://mozilla.locamotion.org/ms/mozilla_lang/
Flags: needinfo?(hitmanarky)
(Reporter)

Comment 4

5 years ago
Terima Kasih Syafiq. Am going to follow-up this bug
Flags: needinfo?(hitmanarky)
http://l10n.mozilla-community.org/~pascalc/langchecker/?locale=ms
The web parts are starting to look good, only a few strings are missing or should be marked with the {ok} tag. I don't know if locamotion allows indicating that a string should remain identical to English, Arky can you see with the team about these strings and see if Locamotion allows that? If not, we will need to patch the ms repo to indicate the strings that should remain identical, data to be provided by the ms team.

Thanks
(Reporter)

Comment 6

5 years ago
(In reply to Pascal Chevrel:pascalc from comment #5)
> I don't know if locamotion allows
> indicating that a string should remain identical to English, Arky can you
> see with the team about these strings and see if Locamotion allows that? If
> not, we will need to patch the ms repo to indicate the strings that should
> remain identical, data to be provided by the ms team.

Pootle doesn't have a feature to tag/mark identical strings. There is a feature request filed against translate toolkit for this. 

Please advise follow up action in the meantime.
As I said, the team should provide a patch marking those strings with the {ok} tag on our source code so as that we get a green dashboard. They can also indicate in this bug which strings should remain in English and we can patch the files for them if needed.
Created attachment 8344585 [details] [diff] [review]
Bug883903_mark_identical_strings.diff

Pascal, I just doing patch fix and commit into svn. You may checking again if the issue still available.
Attachment #8344585 - Flags: review?(pascalc)

Updated

5 years ago
Attachment #8344585 - Flags: review?(pascalc) → review+
ms is in product-details with Aurora activated:
http://viewvc.svn.mozilla.org/vc/libs/product-details/firefoxDetails.class.php?revision=123113&view=markup#l508

ms is activated in Bedrock (Python site) as a supported locale:
https://github.com/mozilla/bedrock/blob/master/bedrock/settings/base.py#L40

ms is activated for all old urls on the PHP site:
http://viewvc.svn.mozilla.org/vc?view=revision&revision=123276

Home page and other prominent pages in Malay:
https://www.mozilla.org/ms/
http://www.mozilla.org/ms/contribute/
http://www.mozilla.org/ms/products/
http://www.mozilla.org/ms/mission/
http://www.mozilla.org/ms/about/

Plugincheck app:
https://www.mozilla.org/ms/plugincheck/

Channel page for downloads of Aurora/Beta:
http://www.mozilla.org/ms/firefox/channel/

Download page for when the locale is on the release channel:
http://www.mozilla.org/ms/firefox/new/

Closing this bug as the locale is in good shape regarding web parts for shipping. Please note that this is a photography of the state of the site as of today, what matters for shipping Firefox is the state of the web parts when we do release it, so these pages need to be maintained, there are on average 20 new strings per week on mozilla.org/fhr.

Thanks!
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED

Comment 10

5 years ago
(In reply to Pascal Chevrel:pascalc from comment #5)
> http://l10n.mozilla-community.org/~pascalc/langchecker/?locale=ms
> The web parts are starting to look good, only a few strings are missing or
> should be marked with the {ok} tag. I don't know if locamotion allows
> indicating that a string should remain identical to English, Arky can you
> see with the team about these strings and see if Locamotion allows that? If
> not, we will need to patch the ms repo to indicate the strings that should
> remain identical, data to be provided by the ms team.
> 
> Thanks

Hi Pascal,

The PO file will have translations as such:

blank - no translation - equivalent to same source and target without {ok} in .lang
translate - obvious
same - i.e. source == target - equivalent to text with {ok} in .lang

Hope that answers your question
So, if I understand it correctly, the localizer just needs to copy and paste the original string in the localization field to mark it as {ok}.
(In reply to Dwayne Bailey from comment #10)
> (In reply to Pascal Chevrel:pascalc from comment #5)
> > http://l10n.mozilla-community.org/~pascalc/langchecker/?locale=ms
> > The web parts are starting to look good, only a few strings are missing or
> > should be marked with the {ok} tag. I don't know if locamotion allows
> > indicating that a string should remain identical to English, Arky can you
> > see with the team about these strings and see if Locamotion allows that? If
> > not, we will need to patch the ms repo to indicate the strings that should
> > remain identical, data to be provided by the ms team.
> > 
> > Thanks
> 
> Hi Pascal,
> 
> The PO file will have translations as such:
> 
> blank - no translation - equivalent to same source and target without {ok}
> in .lang
> translate - obvious
> same - i.e. source == target - equivalent to text with {ok} in .lang
> 
> Hope that answers your question

Dwayne,

I have question according your information above. We have a lot string blank for translate in Firefox Aurora. How could fix this seem it show as incompleted in Pootle ms dashboard?
Created attachment 8346376 [details]
blank string.jpg
Attachment #8346376 - Flags: review?(dwayne)

Comment 14

5 years ago
(In reply to Francesco Lodolo [:flod] from comment #11)
> So, if I understand it correctly, the localizer just needs to copy and paste
> the original string in the localization field to mark it as {ok}.

Correct, just copying it in Pootle means to us that the translator has specifically chosen to keep that string untranslated.

They can always find those strings again using the 'Unchanged' check.

For Web parts we're relying on your tools to do the right thing re {ok} markers.

Comment 15

5 years ago
(In reply to Muhammad Syafiq Mazli from comment #13)
> Created attachment 8346376 [details]
> blank string.jpg

This is unrelated to the main bug, but let me answer you here.

The issue arise because sometimes the DTD and .properties entries are in fact blank and either are used for configuration i.e. you add something, or are used is concatenated sentences e.g. something.start and something.end.

The easiest workaround at the moment is to add a single space to such strings.  It isn't ideal but it seems to have no negative consequences at the moment.

Hope that helps.

Updated

5 years ago
Attachment #8346376 - Flags: review?(dwayne) → review-
You need to log in before you can comment on or make changes to this bug.