883931 - DebuggerClient.prototype.connect may never call callback

Status: RESOLVED WONTFIX

(DevTools :: Debugger, defect, P4)

Description

[(not reading bugmail) Nick Desaulniers [:\n]]

We use this in the simulator for pushing apps to device.  The only issue is that sometimes the push fails due to lack of connection, but we don't notify the user.  I'm working to add support for that. [1]

I've noticed that the failures occur when we try to call DebuggerClient.prototype.connect. [2]

The callback is never invoked when the connection fails, which is unfortunate because we're trying to resolve or reject a promise in the callback.  I was going to add a timer that automatically rejects the promise unless the connection succeeds, but it would be nice if the connect function took and error callback invoked the callback with an error object, since timeouts are super brittle. [3]

[1] https://github.com/mozilla/r2d2b2g/issues/593
[2] https://github.com/mozilla/r2d2b2g/blob/add6f06a2444ef4b3dad35a4bb7a6be7a4869503/addon/lib/debugger.js#L50
[3] http://mxr.mozilla.org/mozilla-central/source/toolkit/devtools/client/dbg-client.jsm#337

Comment 1

[(not reading bugmail) Nick Desaulniers [:\n]]

*but it would be nice if the connect function took an error callback or invoked the callback with an error object*

Comment 2

[Alexandre Poirot [:ochameau]]

What about listening for `close` event, does it fire in case of timeout/connection issue?

Comment 3

[(not reading bugmail) Nick Desaulniers [:\n]]

I tried passing a callback to (new DebuggerClient(...)).onClosed but it was never called.

Comment 4

[Jason Laster [:jlast]]

Closing this bug because we're currently moving away from clients in favor of fronts / protocol.js