883981 - correctly reflect the server's port in httpd.js

Status: RESOLVED FIXED

(Testing :: General, defect)

Comment 1

[Nathan Froyd [:froydnj]]

Attachment: correctly reflect the server's port in httpd.js

httpd.start says that you can pass -1 in to automagically choose a port.
Unfortunately, the identity of that port is not correctly reflected in the
ServerIdentity that the server exposes, since the -1 port is passed directly
in to ServerIdentity, with bad consequences:

http://mxr.mozilla.org/mozilla-central/source/netwerk/test/httpserver/httpd.js#903

Instead, initialize the ServerIdentity with the port from the listening socket
we initialized.

Comment 2

[(not currently active) Ted Mielczarek]

Comment on attachment 763714 [details] [diff] [review]
correctly reflect the server's port in httpd.js

Review of attachment 763714 [details] [diff] [review]:
-----------------------------------------------------------------

Does -1 actually work? I know zero is the common way to do this at the actual BSD socket API level.

Comment 3

[Nathan Froyd [:froydnj]]

(In reply to Ted Mielczarek [:ted.mielczarek] from comment #2)
> Does -1 actually work? I know zero is the common way to do this at the
> actual BSD socket API level.

nsServerSocket will accept 0, but nsIServerSocket and nsIHttpServer both document -1 as the "let a port be chosen for me".  So it seemed better to use that instead.

Comment 4

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/c660bb960b57