Closed
Bug 884004
Opened 8 years ago
Closed 8 years ago
DexClassLoader should use ClassLoader from the context
Categories
(Firefox for Android Graveyard :: General, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
Firefox 26
People
(Reporter: sriram, Assigned: sriram)
Details
Attachments
(1 file)
1.87 KB,
patch
|
kats
:
review+
|
Details | Diff | Splinter Review |
DexClassLoader should use the application's context instead of the System's classloader. This makes it work with org.mozilla.gecko package.
Assignee | ||
Comment 1•8 years ago
|
||
Attachment #763749 -
Flags: review?(bugmail.mozilla)
Comment 2•8 years ago
|
||
Comment on attachment 763749 [details] [diff] [review] Patch Review of attachment 763749 [details] [diff] [review]: ----------------------------------------------------------------- LGTM, thanks!
Attachment #763749 -
Flags: review?(bugmail.mozilla) → review+
Assignee | ||
Comment 3•8 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/b5854baf067d
Comment 4•8 years ago
|
||
Backed out in https://hg.mozilla.org/integration/mozilla-inbound/rev/a883e4e86af9 - armv6 mochitest-1 and mochitest-3 were unhappy, doing the "just stop" thing I'm told is usually a crash either hidden away elsewhere in the log or not logged at all, like https://tbpl.mozilla.org/php/getParsedLog.php?id=24262393&tree=Mozilla-Inbound and https://tbpl.mozilla.org/php/getParsedLog.php?id=24260513&tree=Mozilla-Inbound
Comment 5•8 years ago
|
||
That's super weird, since the code changed shouldn't even be running on tbpl.
Assignee | ||
Comment 6•8 years ago
|
||
Yes, try says success: https://tbpl.mozilla.org/?tree=Try&rev=20e754dd5e34 But no, I pushed it to inbound: https://hg.mozilla.org/integration/mozilla-inbound/rev/aad7f060dadb I hope its not a problem as this is a very small change that no one is going to worry about.
Comment 7•8 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/aad7f060dadb
Assignee: nobody → sriram
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 26
Updated•3 months ago
|
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•