884004 - DexClassLoader should use ClassLoader from the context

Status: RESOLVED FIXED

(Firefox for Android :: General, defect)

Description

[Sriram Ramasubramanian [:sriram]]

DexClassLoader should use the application's context instead of the System's classloader. This makes it work with org.mozilla.gecko package.

Comment 1

[Sriram Ramasubramanian [:sriram]]

Attachment: Patch

Comment 2

[Kartikaya Gupta (email:[e-mail]) (away until Feb-2020)]

Comment on attachment 763749 [details] [diff] [review]
Patch

Review of attachment 763749 [details] [diff] [review]:
-----------------------------------------------------------------

LGTM, thanks!

Comment 3

[Sriram Ramasubramanian [:sriram]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/b5854baf067d

Comment 4

[Phil Ringnalda (:philor)]

Backed out in https://hg.mozilla.org/integration/mozilla-inbound/rev/a883e4e86af9 - armv6 mochitest-1 and mochitest-3 were unhappy, doing the "just stop" thing I'm told is usually a crash either hidden away elsewhere in the log or not logged at all, like https://tbpl.mozilla.org/php/getParsedLog.php?id=24262393&tree=Mozilla-Inbound and https://tbpl.mozilla.org/php/getParsedLog.php?id=24260513&tree=Mozilla-Inbound

Comment 5

[Kartikaya Gupta (email:[e-mail]) (away until Feb-2020)]

That's super weird, since the code changed shouldn't even be running on tbpl.

Comment 6

[Sriram Ramasubramanian [:sriram]]

Yes, try says success: https://tbpl.mozilla.org/?tree=Try&rev=20e754dd5e34
But no, I pushed it to inbound: https://hg.mozilla.org/integration/mozilla-inbound/rev/aad7f060dadb
I hope its not a problem as this is a very small change that no one is going to worry about.

Comment 7

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/aad7f060dadb