884080 - [email] Reply-to-all does not filter out the active account's own e-mail address from recipient lists

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::E-Mail, defect, P2)

Description

[Mila Davydova]

Attachment: Screenshots

Description
When user receives an email with more then 1 recipient and taps on the "Reply to all" button, the new email compose message with original text opens up. However, the email address of the sender still appears in the recipients list.

Repro Steps:
1) Updated to Leo Build ID: 20130610070206
2) Set up an email account on the device
3) Open an email from the account's Inbox which has more then 1 recipient and has at least 1 in both the "To" and the "CC" fields
4) Tap the Reply All button
5) Verify that the email sender address does not appear in the recipients list

Actual:
The email sender address appears in the recipients list

Expected:
The email sender address does not appear in the recipients list

Environmental Variables
Gecko: http://hg.mozilla.org/releases/mozilla-b2g18/rev/8e3f39363c54
Gaia: ce3b99781d182ad550a325206990c249b0dbcf0e
Platform Version: 18.0

Notes:
Repro frequency: 100
Test Suite Name: Email
UCID: (email-117)
Link to failed test case: https://moztrap.mozilla.org/runtests/run/1475/env/314/?pagenumber=1&pagesize=20&sortfield=order&sortdirection=asc&filter-id=4390
Q Analysts Team Priority: Pri 3
See attached: screenshots for more info

Comment 1

[Andrew Sutherland [:asuth] (he/him)]

Comment 0's use of the term "sender address" is ambiguous because there are two special e-mail addresses in this situation to whom it could apply:
1) The e-mail address of the author of the received message (who sent the message).
2) The e-mail address of the active e-mail account (who will send the reply).

We currently avoid adding case 1 to the recipients list if they are already present on the list, but we make no effort to address case 2 by filtering out recipients.  This is a bug and inconsistency on our part; Thunderbird does perform the filtration step.

Comment 2

[Alex Keybl [:akeybl]]

We should slate this enhancement for v1.2 or later. Not a blocker for v1.1.

Comment 3

[Andrew Sutherland [:asuth] (he/him)]

(clearing QE4 target because it's not leo+)

Comment 6

[Peipei Cheng (needinfo if you need my action)]

still reproducible on latest V1.2 and V1.3

buri V1.2 build
Gaia:     075e60c878b0eca68fba9e00bc85cb6eac03578a                         
Gecko:                                                                     
http://hg.mozilla.org/releases/mozilla-b2g26_v1_2/rev/14868788d50e         
BuildID   20131202004001                                                   
Version   26.0                                                             
ro.build.version.incremental=eng.archermind.20131114.105818  

buri V1.3 build
Gaia:     df070d4eed244e782dd3a7c2a7586d0741eac09f                         
Gecko:    http://hg.mozilla.org/mozilla-central/rev/9ac7ed427cd2           
BuildID   20131203151100                                                   
Version   28.0a1                                                           
ro.build.version.incremental=eng.zxliu.20131101.143946

Comment 7

[Jason Smith [:jsmith]]

Not a regression, so this is not a blocker.

Comment 8

[Jack Liu]

This is potential blocker of IOT

Comment 9

[Preeti Raghunath(:Preeti)]

What's the expected functionality? Not sure if its designed this way. Adding product to help with understanding the same.

Comment 10

[Andrew Sutherland [:asuth] (he/him)]

(In reply to Preeti Raghunath(:Preeti) from comment #9)
> What's the expected functionality? Not sure if its designed this way. Adding
> product to help with understanding the same.

Quoting comment 1:

===
Comment 0's use of the term "sender address" is ambiguous because there are two special e-mail addresses in this situation to whom it could apply:
1) The e-mail address of the author of the received message (who sent the message).
2) The e-mail address of the active e-mail account (who will send the reply).

We currently avoid adding case 1 to the recipients list if they are already present on the list, but we make no effort to address case 2 by filtering out recipients.  This is a bug and inconsistency on our part; Thunderbird does perform the filtration step.
===

Comment 11

[Jason Smith [:jsmith]]

Discussed via Vance - there's agreement now this isn't a blocker.

Comment 13

[Noemí Freire (:noemi)]

Due to it is a really bad user experience nominating to v1.4? to be considered. Thanks!

Comment 14

[Wilfred Mathanaraj [:WDM]]

this is bad user experience and should block v1.4. we need to fix this.

Comment 15

[Peter Dolanjski [:pdol]]

(In reply to Andrew Sutherland (:asuth) from comment #1)
> Comment 0's use of the term "sender address" is ambiguous because there are
> two special e-mail addresses in this situation to whom it could apply:
> 1) The e-mail address of the author of the received message (who sent the
> message).
> 2) The e-mail address of the active e-mail account (who will send the reply).
> 
> We currently avoid adding case 1 to the recipients list if they are already
> present on the list, but we make no effort to address case 2 by filtering
> out recipients.  This is a bug and inconsistency on our part; Thunderbird
> does perform the filtration step.

Based on triage discussion, the concern was indeed about case 2.

Comment 16

[Preeti Raghunath(:Preeti)]

Blocking for 1.4

Comment 17

[Marcus Cavanaugh [:mcav]]

Attachment: Link to Github pull-request: https://github.com/mozilla-b2g/gaia-email-libs-and-more/pull/301

Comment 18

[Andrew Sutherland [:asuth] (he/him)]

Comment on attachment 8406307 [details] [review]
Link to Github pull-request: https://github.com/mozilla-b2g/gaia-email-libs-and-more/pull/301

greet! thanks!

Comment 19

[Marcus Cavanaugh [:mcav]]

GELAM: https://github.com/mcav/gaia-email-libs-and-more/commit/0bc01c402132d9eb8f4b48c6b401f27c1a50426c

Gaia master: https://github.com/mcav/gaia/commit/6904deba65e6616129b981616c0f4d0e9c97be62

Comment 20

[Ryan VanderMeulen [:RyanVM]]

v1.4: https://github.com/mozilla-b2g/gaia/commit/441c4bcd8ac4f8c01a9bc5a2f8d64eaa87844803

Comment 21

[Edward Chen[:edchen]]

I observed a situation that needs to be comfirmed. If I used to my gmail account send to myslf and other people, and then reply to all, I saw my gmail account does be filered out. Please see my steps below.

[Reproduce]
1. Set a gmail accout_1 
2. Send a mail to other people and self with account_1
3. Go to account_1 inbox to check this mail
4. Reply to all
5. You can see the account_1 has been filter out in recipient list that means the recipient listis empty . This is a little bit strange. 


[Environment]
Gaia      3d47c0627017ef77b1adf179792c6543a349af72
Gecko     https://hg.mozilla.org/mozilla-central/rev/1f932e462b84
BuildID   20140415160202
Version   31.0a1
ro.build.version.incremental=eng.archermind.20131114.105818
ro.build.date=Thu Nov 14 10:58:33 CST 2013


[Result]
PASS