Last Comment Bug 884178 - [patch] add PK11_CipherFinal macro
: [patch] add PK11_CipherFinal macro
Product: NSS
Classification: Components
Component: Libraries (show other bugs)
: trunk
: x86_64 Linux
P2 enhancement (vote)
: 3.15.2
Assigned To: Milan Bartos
Depends on:
  Show dependency treegraph
Reported: 2013-06-17 23:04 PDT by Milan Bartos
Modified: 2013-09-25 15:00 PDT (History)
3 users (show)
See Also:
Crash Signature:
QA Whiteboard:
Iteration: ---
Points: ---

add_PK11_CipherFinal.patch (1.50 KB, text/plain)
2013-06-17 23:04 PDT, Milan Bartos
no flags Details
add PK11_CipherFinal - #define (777 bytes, patch)
2013-06-20 01:08 PDT, Milan Bartos
rrelyea: review+
Details | Diff | Splinter Review

Description User image Milan Bartos 2013-06-17 23:04:52 PDT
Created attachment 763989 [details]

User Agent: Mozilla/5.0 (X11; Linux x86_64; rv:21.0) Gecko/20100101 Firefox/21.0 (Beta/Release)
Build ID: 20130516103852

Steps to reproduce:

This patch adds function wrapper PK11_CipherFinal for consistency when using PK11_CipherOp.
Comment 1 User image Milan Bartos 2013-06-20 01:08:06 PDT
Created attachment 765235 [details] [diff] [review]
add PK11_CipherFinal - #define
Comment 2 User image Robert Relyea 2013-06-20 08:58:33 PDT
Comment on attachment 765235 [details] [diff] [review]
add PK11_CipherFinal - #define

r+ for the change to pk11pub.h

r- for the change to nss.def

the #define means the application has PK11_CipherFinal in the code, but the linker will see PK11_DigestFinal.
Comment 3 User image Ryan VanderMeulen [:RyanVM] 2013-07-01 06:23:00 PDT
Kai, can you land this please? :)
Comment 4 User image Kai Engert (:kaie) 2013-07-02 03:48:01 PDT
> can you land this please?

Comment 5 User image Kai Engert (:kaie) 2013-07-02 10:59:55 PDT
Patch failed to build on most platforms, only Linux builds worked.

Backed out:
Comment 6 User image Kai Engert (:kaie) 2013-07-02 11:01:10 PDT
Please look at build logs available at
Comment 7 User image Robert Relyea 2013-07-02 17:06:57 PDT
Kai, only the header file needs to be checked in. I r-'ed the nss.def change as not necessary (actually wrong).
Comment 8 User image Kai Engert (:kaie) 2013-07-03 14:46:05 PDT
Checked in header change.
Comment 9 User image Wan-Teh Chang 2013-07-26 10:18:09 PDT
It may be better to add PK11_CipherFinal as a real function, so that
one can set a breakpoint for PK11_CipherFinal in a debugger without
looking at the header file.
Comment 10 User image Milan Bartos 2013-07-29 22:57:41 PDT
It may be better if there are some development guideline for this kind of stuff.
Comment 11 User image Robert Relyea 2013-07-30 11:05:20 PDT
wtc, actually Milan proposed an actual function, I prefered the #define. it's far from the only #define to alias names in NSS...

Comment 12 User image Wan-Teh Chang 2013-09-25 15:00:39 PDT
Updated the Summary field to reflect what was actually added.

Note You need to log in before you can comment on or make changes to this bug.