Created attachment 763989 [details] add_PK11_CipherFinal.patch User Agent: Mozilla/5.0 (X11; Linux x86_64; rv:21.0) Gecko/20100101 Firefox/21.0 (Beta/Release) Build ID: 20130516103852 Steps to reproduce: This patch adds function wrapper PK11_CipherFinal for consistency when using PK11_CipherOp.
Created attachment 765235 [details] [diff] [review] add PK11_CipherFinal - #define
Comment on attachment 765235 [details] [diff] [review] add PK11_CipherFinal - #define r+ for the change to pk11pub.h r- for the change to nss.def the #define means the application has PK11_CipherFinal in the code, but the linker will see PK11_DigestFinal.
Kai, can you land this please? :)
> can you land this please? done https://hg.mozilla.org/projects/nss/rev/a47bc2881ba4
Patch failed to build on most platforms, only Linux builds worked. Backed out: https://hg.mozilla.org/projects/nss/rev/62facccdaaaf
Please look at build logs available at https://nss-crypto.org:8011/waterfall
Kai, only the header file needs to be checked in. I r-'ed the nss.def change as not necessary (actually wrong).
Checked in header change. https://hg.mozilla.org/projects/nss/rev/804af8ec3e1f
It may be better to add PK11_CipherFinal as a real function, so that one can set a breakpoint for PK11_CipherFinal in a debugger without looking at the header file.
It may be better if there are some development guideline for this kind of stuff.
wtc, actually Milan proposed an actual function, I prefered the #define. it's far from the only #define to alias names in NSS... bob
Updated the Summary field to reflect what was actually added.