[patch] add PK11_CipherFinal macro

RESOLVED FIXED in 3.15.2

Status

P2
enhancement
RESOLVED FIXED
6 years ago
5 years ago

People

(Reporter: mbartos, Assigned: mbartos)

Tracking

trunk
3.15.2
x86_64
Linux

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 1 obsolete attachment)

(Assignee)

Description

6 years ago
Created attachment 763989 [details]
add_PK11_CipherFinal.patch

User Agent: Mozilla/5.0 (X11; Linux x86_64; rv:21.0) Gecko/20100101 Firefox/21.0 (Beta/Release)
Build ID: 20130516103852

Steps to reproduce:

This patch adds function wrapper PK11_CipherFinal for consistency when using PK11_CipherOp.
(Assignee)

Comment 1

6 years ago
Created attachment 765235 [details] [diff] [review]
add PK11_CipherFinal - #define
Attachment #763989 - Attachment is obsolete: true

Comment 2

6 years ago
Comment on attachment 765235 [details] [diff] [review]
add PK11_CipherFinal - #define

r+ for the change to pk11pub.h

r- for the change to nss.def

the #define means the application has PK11_CipherFinal in the code, but the linker will see PK11_DigestFinal.
Attachment #765235 - Flags: review+

Updated

6 years ago
Status: UNCONFIRMED → ASSIGNED
Ever confirmed: true
Keywords: checkin-needed
Assignee: nobody → nobody
Component: General → Libraries
Product: Core → NSS
Version: Trunk → trunk
Kai, can you land this please? :)
Flags: needinfo?(kaie)
> can you land this please?

done
https://hg.mozilla.org/projects/nss/rev/a47bc2881ba4
Status: ASSIGNED → RESOLVED
Last Resolved: 6 years ago
Flags: needinfo?(kaie)
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → 3.15.2
Patch failed to build on most platforms, only Linux builds worked.

Backed out:
https://hg.mozilla.org/projects/nss/rev/62facccdaaaf
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Please look at build logs available at https://nss-crypto.org:8011/waterfall

Comment 7

6 years ago
Kai, only the header file needs to be checked in. I r-'ed the nss.def change as not necessary (actually wrong).
Checked in header change.

https://hg.mozilla.org/projects/nss/rev/804af8ec3e1f
Status: REOPENED → RESOLVED
Last Resolved: 6 years ago6 years ago
Resolution: --- → FIXED

Comment 9

6 years ago
It may be better to add PK11_CipherFinal as a real function, so that
one can set a breakpoint for PK11_CipherFinal in a debugger without
looking at the header file.
(Assignee)

Comment 10

6 years ago
It may be better if there are some development guideline for this kind of stuff.

Comment 11

6 years ago
wtc, actually Milan proposed an actual function, I prefered the #define. it's far from the only #define to alias names in NSS...

bob

Comment 12

5 years ago
Updated the Summary field to reflect what was actually added.
Assignee: nobody → mbartos
Severity: normal → enhancement
Priority: -- → P2
Summary: [patch] add PK11_CipherFinal function wrapper → [patch] add PK11_CipherFinal macro
You need to log in before you can comment on or make changes to this bug.