884189 - Allow sending of Uint8Array via Request

Status: RESOLVED FIXED

(Add-on SDK Graveyard :: Documentation, defect, P2)

Description

[Ben McCann]

User Agent: Mozilla/5.0 (Windows NT 6.1; WOW64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/27.0.1453.110 Safari/537.36

Steps to reproduce:

I would like to send a Request to my server with Uint8Array data


Actual results:

I can send in a normal webpage with an XMLHttpRequest, but cannot send with the extension's Request API


Expected results:

It should behave the same as XMLHttpRequest:
https://developer.mozilla.org/en-US/docs/Web/API/XMLHttpRequest/Sending_and_Receiving_Binary_Data

This works in Chrome extensions since Chrome extensions use XMLHttpRequest and do not have a separate Request API for extensions. The separate API is frustrating and not as easy to develop for as Chrome's use of XMLHttpRequest.

Comment 1

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

Lets just promote the xhr module to stable, and point to it from the Request module docs saying that it's more useful to do more advanced requests.

Comment 2

[Ben McCann]

Sounds great to me! I didn't realize that it existed initially. Is there any reason I shouldn't use net/xhr everywhere instead of sdk/request? I like it so much more because it's closer to the Chrome API and the standard web API that's used everywhere.

Comment 3

[Jordan Santell [:jsantell] [@jsantell]]

Thoughts on making `net/xhr` stable?

Comment 4

[Irakli Gozalishvili [:irakli] [:gozala] [@gozala]]

I'm down for that!

Comment 5

[Jordan Santell [:jsantell] [@jsantell]]

Attachment: GH PR 1148

Comment 6

[Will Bamberg [:wbamberg]]

Comment on attachment 785816 [details]
GH PR 1148

Just one wording change to suggest, so if that's done I'm happy with this. We should make the net/xhr documentation better though -> bug 901653.

Comment 7

[[github robot]]

Commits pushed to master at https://github.com/mozilla/addon-sdk

https://github.com/mozilla/addon-sdk/commit/99a4e9a9c846eb5685cea232e1aff3f1c55eb0c6
Bug 884189 promote net/xhr module from Request

https://github.com/mozilla/addon-sdk/commit/ea81adc34cc774e7564ad6051c392fb566ae764c
Merge pull request #1148 from jsantell/promote-xhr-module

Fix Bug 884189 promote net/xhr module from Request, r=@wbamberg