Closed Bug 884298 Opened 9 years ago Closed 9 years ago

IonMonkey: Allow inlining of functions containing JSOP_FUNCALL

Categories

(Core :: JavaScript Engine, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla24

People

(Reporter: h4writer, Assigned: h4writer)

References

Details

Attachments

(1 file)

As far as I know there is no real reason not to inline functions that contain a JSOP_FUNCALL. So do this. This improves deltablue a little bit (Around 1% or something).
Blocks: 768739
Attached patch PatchSplinter Review
Quick and easy patch. Else the constructors in deltablue can't get inlined. And the functions are really small. And most of the time is lost into boxing/unboxing the arguments. (Esp. ScaleConstraint)
Assignee: nobody → hv1989
Attachment #764372 - Flags: review?(jdemooij)
Comment on attachment 764372 [details] [diff] [review]
Patch

Review of attachment 764372 [details] [diff] [review]:
-----------------------------------------------------------------

Good catch.
Attachment #764372 - Flags: review?(jdemooij) → review+
https://hg.mozilla.org/mozilla-central/rev/01068ed464ca
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla24
Depends on: 883973
Component: File Handling → JavaScript Engine
You need to log in before you can comment on or make changes to this bug.