IonMonkey: Allow inlining of functions containing JSOP_FUNCALL

RESOLVED FIXED in mozilla24

Status

()

RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: h4writer, Assigned: h4writer)

Tracking

unspecified
mozilla24
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

5 years ago
As far as I know there is no real reason not to inline functions that contain a JSOP_FUNCALL. So do this. This improves deltablue a little bit (Around 1% or something).
(Assignee)

Updated

5 years ago
Blocks: 768739
(Assignee)

Comment 1

5 years ago
Created attachment 764372 [details] [diff] [review]
Patch

Quick and easy patch. Else the constructors in deltablue can't get inlined. And the functions are really small. And most of the time is lost into boxing/unboxing the arguments. (Esp. ScaleConstraint)
Assignee: nobody → hv1989
Attachment #764372 - Flags: review?(jdemooij)
Comment on attachment 764372 [details] [diff] [review]
Patch

Review of attachment 764372 [details] [diff] [review]:
-----------------------------------------------------------------

Good catch.
Attachment #764372 - Flags: review?(jdemooij) → review+
https://hg.mozilla.org/mozilla-central/rev/01068ed464ca
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla24

Updated

5 years ago
Depends on: 883973

Updated

5 years ago
Component: File Handling → JavaScript Engine
You need to log in before you can comment on or make changes to this bug.