Closed
Bug 884298
Opened 11 years ago
Closed 11 years ago
IonMonkey: Allow inlining of functions containing JSOP_FUNCALL
Categories
(Core :: JavaScript Engine, defect)
Core
JavaScript Engine
Tracking
()
RESOLVED
FIXED
mozilla24
People
(Reporter: h4writer, Assigned: h4writer)
References
Details
Attachments
(1 file)
|
911 bytes,
patch
|
jandem
:
review+
|
Details | Diff | Splinter Review |
As far as I know there is no real reason not to inline functions that contain a JSOP_FUNCALL. So do this. This improves deltablue a little bit (Around 1% or something).
|
Assignee | |
Comment 1•11 years ago
|
||
Quick and easy patch. Else the constructors in deltablue can't get inlined. And the functions are really small. And most of the time is lost into boxing/unboxing the arguments. (Esp. ScaleConstraint)
Assignee: nobody → hv1989
Attachment #764372 -
Flags: review?(jdemooij)
|
||
Comment 2•11 years ago
|
||
Comment on attachment 764372 [details] [diff] [review]
Patch
Review of attachment 764372 [details] [diff] [review]:
-----------------------------------------------------------------
Good catch.
Attachment #764372 -
Flags: review?(jdemooij) → review+
|
|
Assignee | |
Comment 3•11 years ago
|
||
|
||
Comment 4•11 years ago
|
||
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla24
|
||
Updated•11 years ago
|
Component: File Handling → JavaScript Engine
You need to log in
before you can comment on or make changes to this bug.
Description
•