884355 - "Warn me when closing multiple tabs" should warn when "Never remember history" is enabled

Status: VERIFIED FIXED

(Firefox :: Private Browsing, defect)

Description

[Graeme Hewson]

User Agent: Mozilla/5.0 (X11; Ubuntu; Linux x86_64; rv:21.0) Gecko/20100101 Firefox/21.0 (Beta/Release)
Build ID: 20130512193848

Steps to reproduce:

In the Privacy preferences, configure Firefox to "Never remember history". Keep the default "Warn me when closing multiple tabs".

Go to some site. Middle click on a link to open a new tab. Secondary click on another link and Open Link in New Private Window. (Note that because of the Privacy setting, there's no entry to Open Link in New Window in the File menu.) Middle click on a link in this window.


Actual results:

There are now two windows with two tabs each. Close one of the windows, using the mouse or the keyboard. It closes with no warning. The remaining window will present a warning if you try to close it.

The same happens if you have two (or more) windows started from the startup window, and you closed the startup window. All windows except the last remaining window close without warning.


Expected results:

I suggest there should be consistency. My preference is that all windows should respect the "Warn me when closing multiple tabs" setting. Failing that, I suggest: (i) the last window should also close without warning; (ii) the multiple tabs setting should be greyed out.

(This follows on from bug 884241, the 8th comment. I'm making the argument.)

Comment 1

[Josh Matthews [:jdm]]

Updating the isPBWindow value in warnAboutClosingWindow (http://mxr.mozilla.org/mozilla-central/source/browser/base/content/browser.js#6014) to check for permanent PB mode as well (http://mxr.mozilla.org/mozilla-central/source/toolkit/modules/PrivateBrowsingUtils.jsm#29) would fix this, I believe.

Comment 2

[[github robot]]

Commits pushed to master at https://github.com/mozilla/webmaker.org

https://github.com/mozilla/webmaker.org/commit/5fbbcc52eab183e62e46a415ee4028f012f38388
[bug 884355] Mobile Homepage Tiles and Touch

https://github.com/mozilla/webmaker.org/commit/de280c0cb3762dafdce1ad2cbbddcee015b7ccea
Merge pull request #186 from daleee/884335-mobile-ux-tiles

[bug 884355] Mobile Homepage Tiles and Touch

Comment 3

[Majda Nafissa Rahal]

Attachment: Check if Never remember history mode is on

Comment 4

[Josh Matthews [:jdm]]

Comment on attachment 766416 [details] [diff] [review]
Check if Never remember history mode is on

Review of attachment 766416 [details] [diff] [review]:
-----------------------------------------------------------------

I apologize for sitting on this for so long! I think we should combine this check with the one above it, since they end up performing the same action. Could you prepare a new patch that does that?

Comment 5

[Josh Matthews [:jdm]]

Attachment: Warn about closing multiple tabs when "Never remember history" is enabled"

Comment 6

[:Gavin Sharp [email: [e-mail]]]

Comment on attachment 780982 [details] [diff] [review]
Warn about closing multiple tabs when "Never remember history" is enabled"

I suppose this seems reasonable, but you should update the comment to explain the various cases (i.e. mention more than just popups).

Comment 7

[Dão Gottwald [:dao]]

Comment on attachment 780982 [details] [diff] [review]
Warn about closing multiple tabs when "Never remember history" is enabled"

>-
>+  

Avoid this change.

Comment 8

[:Gavin Sharp [email: [e-mail]]]

Looks like this was forgotten?

Comment 9

[Graeme Hewson]

What's happening with this?

Comment 10

[Josh Matthews [:jdm]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/0c63a95e2dd8

Comment 11

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/0c63a95e2dd8

Comment 12

[Paul Silaghi, QA [:pauly]]

Reproduced in Nightly 2013-06-18, win 7 x64.
Verified fixed using the STR in comment 0 on FF 29b2, Win 7 x64.
Found another issue - filed bug 987821