Closed Bug 884371 Opened 8 years ago Closed 8 years ago

Remove JSMutableHandleXXX typedefs

Categories

(Core :: JavaScript Engine, defect)

x86
macOS
defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla24

People

(Reporter: jonco, Assigned: jonco)

References

Details

Attachments

(3 files)

The agreed convention is to use JS::MutableHandle<JS::Whatever> in the browser and JS::MutableHandleWhatever in js source, so we should get rid of these typedefs.

Use the browser convention in jsapi.h to provide an example for callers.
Attachment #764208 - Flags: review?(bzbarsky)
Attachment #764209 - Flags: review?(bobbyholley+bmo)
Attachment #764209 - Flags: review?(bobbyholley+bmo) → review+
Comment on attachment 764208 [details] [diff] [review]
1 - Remove JSMutableHandleXXX from the browser

r=me
Attachment #764208 - Flags: review?(bzbarsky) → review+
Comment on attachment 764210 [details] [diff] [review]
3 - Remove JSMutableHandleXXX from the js/src directory

Review of attachment 764210 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks for doing this, Jon!

::: js/src/jsapi.h
@@ -724,5 @@
>  typedef JS::Handle<jsid> JSHandleId;
>  
> -typedef JS::MutableHandle<JSFunction*> JSMutableHandleFunction;
> -typedef JS::MutableHandle<JSString*>   JSMutableHandleString;
> -typedef JS::MutableHandle<JS::Value>   JSMutableHandleValue;

\o/
Attachment #764210 - Flags: review?(terrence) → review+
Blocks: 773686
How about the non-mutable variants?
You need to log in before you can comment on or make changes to this bug.