884371 - Remove JSMutableHandleXXX typedefs

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect)

Description

[Jon Coppeard (:jonco)]

The agreed convention is to use JS::MutableHandle<JS::Whatever> in the browser and JS::MutableHandleWhatever in js source, so we should get rid of these typedefs.

Use the browser convention in jsapi.h to provide an example for callers.

Comment 1

[Jon Coppeard (:jonco)]

Attachment: 1 - Remove JSMutableHandleXXX from the browser

Comment 2

[Jon Coppeard (:jonco)]

Attachment: 2 - Remove JSMutableHandleXXX from the js directory

Comment 3

[Jon Coppeard (:jonco)]

Attachment: 3 - Remove JSMutableHandleXXX from the js/src directory

Comment 4

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 764208 [details] [diff] [review]
1 - Remove JSMutableHandleXXX from the browser

r=me

Comment 5

[Terrence Cole [:terrence]]

Comment on attachment 764210 [details] [diff] [review]
3 - Remove JSMutableHandleXXX from the js/src directory

Review of attachment 764210 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks for doing this, Jon!

::: js/src/jsapi.h
@@ -724,5 @@
>  typedef JS::Handle<jsid> JSHandleId;
>  
> -typedef JS::MutableHandle<JSFunction*> JSMutableHandleFunction;
> -typedef JS::MutableHandle<JSString*>   JSMutableHandleString;
> -typedef JS::MutableHandle<JS::Value>   JSMutableHandleValue;

\o/

Comment 6

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

How about the non-mutable variants?

Comment 7

[Jon Coppeard (:jonco)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/693f9855e226
https://hg.mozilla.org/integration/mozilla-inbound/rev/f126bff5d429
https://hg.mozilla.org/integration/mozilla-inbound/rev/ccdd6aa7b488

Comment 8

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/693f9855e226
https://hg.mozilla.org/mozilla-central/rev/f126bff5d429
https://hg.mozilla.org/mozilla-central/rev/ccdd6aa7b488