884509 - Gecko Profiler add-on holds 100MBs of memory even if disabled

Status: RESOLVED INACTIVE

(Core :: Gecko Profiler, defect)

Description

[Vladan Djeric (:vladan)]

Attachment: about:memory snapshot

STR:

1. Open a profile
2. Check SymbolicateWorker.js memory use in about:memory
3. Disable add-on & click "Minimize memory usage" in about:memory

Expected: SymbolicateWorker.js memory use goes to 0 in about:memory
Actual: SymbolicateWorker.js keeps using >100MB of memory

Kyle, can you suggest any extra diagnostic steps? Could it be that the add-on simply isn't shutting down its worker?

Comment 1

[Benoit Girard (:BenWa)]

(In reply to Vladan Djeric (:vladan) from comment #0)
> Kyle, can you suggest any extra diagnostic steps? Could it be that the
> add-on simply isn't shutting down its worker?

The GC/CC should clean it up. Why is it staying alive after the addon is removed?

Comment 2

[Kyle Huey (Exited; not receiving bugmail, old account, do not use)]

Well the addon is clearly still around in that about:memory report.

Comment 3

[Benoit Girard (:BenWa)]

Could disabling the addon not release everything required?

Comment 4

[Kyle Huey (Exited; not receiving bugmail, old account, do not use)]

I don't know.  That's a jetpack question.

Comment 5

[Dave Townsend [:mossop]]

(In reply to Benoit Girard (:BenWa) from comment #3)
> Could disabling the addon not release everything required?

It should, but this could be a leak in the SDK modules or the add-on's code not properly listening for the unload event.

Comment 6

[Ben Turner (not reading bugmail, use the needinfo flag!)]

Keep in mind that workers will hold themselves alive if they're doing things (handling messages, timeouts, loading scripts, etc.), so that could cause the addon to stick around longer than it expects. Calling terminate() on it would kill any internal activity so you might be able to use that here.

Comment 7

[Gerald Squelart (he/him) (not at Mozilla since 2022-09-15)]

Not an add-on anymore.