884516 - Remove JS shell global 'arguments' variable

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect)

Description

[Jason Orendorff [:jorendorff]]

How about we reverse the patch in bug 675269?  The fact that 'arguments' is an array in tests is (empirically) surprising and confusing.

Comment 1

[Luke Wagner [:luke]]

Yes, please.  I remember I was quite confused by the presence of a global 'arguments' binding.

Comment 2

[Jason Orendorff [:jorendorff]]

Attachment: v1

Comment 3

[Luke Wagner [:luke]]

Comment on attachment 764436 [details] [diff] [review]
v1

Review of attachment 764436 [details] [diff] [review]:
-----------------------------------------------------------------

::: js/src/shell/js.cpp
@@ +5254,5 @@
>          || !op.addBoolOption('O', "print-alloc", "Print the number of allocations at exit")
>  #endif
>          || !op.addOptionalStringArg("script", "A script to execute (after all options)")
>          || !op.addOptionalMultiStringArg("scriptArgs",
> +                                         "String arguments to bind as |stringArgs| in the "

s/stringArgs/scriptArgs/

Comment 4

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/4e6407439d45

Comment 5

[Hannes Verschore [:h4writer]]

I got a report from IRC:

<{V}> ... incidentally, arguments.length still reports as 1, but argements[0] is undefined

Could it be that arguments.length is still working, although arguments is removed? Didn't test or looked into myself...

Comment 6

[Hannes Verschore [:h4writer]]

Nvm previous comment. Is a bogus claim ;)