884566 - Don't show Bluetooth as the default Quick Share entry

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Ian Barlow (:ibarlow)]

Currently the default icon in the Share menu is for Bluetooth. Quick Share should only promote share tools that a users actually uses. 

In other words by default the icon area should be blank, and only show an icon once a share service has been used.

Comment 1

[Sriram Ramasubramanian [:sriram]]

Attachment: Patch

( Thanks android for giving history size! )

This shows the default icon only if there's any his/her story.

Comment 2

[Mark Finkle (:mfinkle) (use needinfo?)]

Comment on attachment 766944 [details] [diff] [review]
Patch

You'll need to uplift this to aurora now as well

Comment 3

[Sriram Ramasubramanian [:sriram]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/0767250bcb88

Comment 4

[Ryan VanderMeulen (PTO, back 6-April)]

https://hg.mozilla.org/mozilla-central/rev/0767250bcb88

Comment 5

[Sriram Ramasubramanian [:sriram]]

Comment on attachment 766944 [details] [diff] [review]
Patch

[Approval Request Comment]
Bug caused by (feature/regressing bug #): Bug 869123
User impact if declined: Bluetooth will be shown by default.
Testing completed (on m-c, etc.): Landed on m-c on 06/26
Risk to taking this patch (and alternatives if risky): None. Checks for history size and shows a default activity if one exists.
String or IDL/UUID changes made by this patch: None.

Comment 6

[Sriram Ramasubramanian [:sriram]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/18416a172146

Comment 7

[Teodora Vermesan (:TeoVermesan)]

Verified fixed on:
Build: Firefox for Android 24.0a2(2013-07-03)
Device: LG Nexus 4
OS: Android 4.2.2