884569 - mozpack support for removing untracked files

Status: RESOLVED FIXED

(Firefox Build System :: General, defect)

Description

[Gregory Szorc [:gps]]

I'm splitting off the mozpack work from bug 850380.

Essentially we want code in mozpack to remove "untracked" files from a directory. Essentially, the build system will be able to say "only these files should exist" and this code will purge files that don't belong. This is very similar to how version control systems clean or purge the working directory.

Comment 1

[Gregory Szorc [:gps]]

Attachment: Support for removing untracked files from a directory

Since the XPIDL patch, I renamed DirectoryPruner to FilePurger and added a
class to hold the results of the operation. That class is still minimal.
It can expand as needed.

Comment 2

[Mike Hommey [:glandium]]

Comment on attachment 764424 [details] [diff] [review]
Support for removing untracked files from a directory

Review of attachment 764424 [details] [diff] [review]:
-----------------------------------------------------------------

::: python/mozbuild/mozpack/copier.py
@@ +202,5 @@
> +        return FileCopier.add(self, path, FilePurger.FakeFile())
> +
> +    def purge(self, dest):
> +        """Deletes all files and empty directories not in the registry."""
> +        return FileCopier.copy(self, dest)

Not sure how to do that properly in python, but you may want to make FilePurger.copy not do anything.

::: python/mozbuild/mozpack/test/test_copier.py
@@ +136,5 @@
> +    def setUp(self):
> +        self.tmpdir = mkdtemp()
> +
> +    def tearDown(self):
> +        shutil.rmtree(self.tmpdir)

You can import TestWithTmpDir from test_files.

Comment 3

[Gregory Szorc [:gps]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/ba0b09e110ee

Comment 4

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/ba0b09e110ee