88457 - [xlib] missing some critical cursors / css3 cursors

Status: RESOLVED FIXED

(Core :: XUL, defect, P3)

Description

[pocemit]

Xlib port is missing some critical cursors such as the question-mark generated
by <acronym title=""> and various other cursors.
Patch follows.

Comment 1

[pocemit]

accepting bug, adding gisburn, adding to tracker bug, setting milestone,
priority, keywords.

Comment 2

[pocemit]

Attachment: patch for widget/src/xlib to add cursor support

Comment 3

[pocemit]

Attachment: widget/src/xlib/nsXlibCursors.h

Comment 4

[pocemit]

Attachment: testcase demonstrating new cursors after applying the patch

Comment 5

[pocemit]

This patch adds custom cursor support to xlib toolkit port, adds all (except 3)
css3 cursors, makes the "whats this?" cursor more user-friendly...

Looking for reviews

Comment 6

[pocemit]

Attachment: better looking cursor for "spinning"

Comment 7

[Roland Mainz]

The busy pointer looks weired. I prefer the X/Motif "big clock" image for
"busy"... I do not like that new one...

...

Please make all those array |const| if possible and you'll have
r=[e-mail]

Comment 8

[pocemit]

Attachment: We were leaking a cursor in nsWindow::NativeGrab

Comment 9

[pocemit]

Attachment: Updated Cursors data (const unsigned char)

Comment 10

[pocemit]

Here is how to review this patch:

1. http://bugzilla.mozilla.org/showattachment.cgi?attach_id=40840
2. http://bugzilla.mozilla.org/showattachment.cgi?attach_id=40841

looking for sr=

Comment 11

[tor]

Shouldn't the allocation of the cursor in NativeGrab be moved inside the
"if (aGrab)" block and the deletion be moved to the "else" section?

Comment 12

[pocemit]

No, but thanks for noticing this.
Cursor creation should be moved inside if (aGrab), since there is no sense
making one when grab isnt going to be performed. After cursor grab however it's
safe to delete the cursor.

Attaching modified patch.

Comment 13

[pocemit]

Attachment: new patch with per tor's comments

Comment 14

[pocemit]

Attachment: new patch with per tor's comments

Comment 15

[tor]

r=tor

Comment 16

[pocemit]

Here is how to sr= this patch:

1. http://bugzilla.mozilla.org/showattachment.cgi?attach_id=40938
2. http://bugzilla.mozilla.org/showattachment.cgi?attach_id=40841

(1) is the code change and (2) is the cursor data + structures.
Seeking sr=

Comment 17

[Christopher Blizzard (:blizzard)]

For sr please see comments in bug 38444.  The same applies here.

Comment 18

[pocemit]

Attachment: latest patch to match blizzard's comments

Comment 19

[pocemit]

New patch posted

to review:

a) http://bugzilla.mozilla.org/showattachment.cgi?attach_id=41706
b) http://bugzilla.mozilla.org/showattachment.cgi?attach_id=40841

(a) is the patch and (b) is the cursor data

Comment 20

[pocemit]

Attachment: new patch hashtable replaced by array

Comment 21

[Christopher Blizzard (:blizzard)]

The same comments from 38444 apply here.

Comment 22

[pocemit]

Attachment: final patch from blizzard's comments

Comment 23

[pocemit]

a) attachment 41749 [details] [diff] [review]
b) attachment 40841 [details] [diff] [review]

thank you

Comment 24

[pocemit]

Attachment: new patch, critical crash bug missed by review

Comment 25

[pocemit]

to check-in:

a) attachment 41793 [details] [diff] [review] - patch
b) attachment 40841 [details] [diff] [review] - new file - widget/src/xlib/nsXlibCursors.h

Comment 26

[pocemit]

Attachment: my original patch contained unrelated Makefile.in changes

Comment 27

[pocemit]

Attachment: updated cursor data (changing NPL->MPL)

Comment 28

[pocemit]

Sorry for the spam.

The Xlib cursor patch is ready to check-in:

a) attachment 41858 [details] [diff] [review]
b) attachment 41859 [details] [diff] [review]

Comment 29

[timeless]

fix checked in

Comment 30

[John Morrison]

May God have mercy on us all. The 212 bug spam-o-rama is Now!