Closed
Bug 884576
Opened 12 years ago
Closed 12 years ago
Make some nsBlockFrame methods infallible
Categories
(Core :: Layout: Block and Inline, defect)
Core
Layout: Block and Inline
Tracking
()
RESOLVED
FIXED
mozilla24
People
(Reporter: dholbert, Assigned: dholbert)
References
Details
Attachments
(1 file)
|
10.35 KB,
patch
|
bzbarsky
:
review+
|
Details | Diff | Splinter Review |
I noticed a few helper-methods in nsBlockFrame that are now effectively infallible but still return nsresult (& always return NS_OK).
Filing this bug to clean those up.
|
Assignee | |
Comment 1•12 years ago
|
||
Here are the methods tweaked in this bug's upcoming patch, and the history of them being effectively-infallible:
* nsBlockFrame::ReflowPushedFloats has been infallible since its last NS_ENSURE_SUCCESS was removed in 2010 (though it was named ReflowFloatContinuations back then[1]):
http://hg.mozilla.org/mozilla-central/rev/cf3a58fef285#l1.130
* nsBlockFrame::PrepareResizeReflow has been infallible since the CVS days:
http://mxr.mozilla.org/firefox/source/layout/generic/nsBlockFrame.cpp#1505
* nsBlockFrame::SplitLine() has been infallible since its last non-NS_OK return value was removed in bug 851848:
https://hg.mozilla.org/mozilla-central/rev/a68dd0799cf6#l1.21
[1] (That renaming happened in http://hg.mozilla.org/mozilla-central/rev/8ab7ef79b673 )
|
|
Assignee | |
Comment 2•12 years ago
|
||
|
||
Comment 3•12 years ago
|
||
Comment on attachment 764423 [details] [diff] [review]
fix v1
r=me
Attachment #764423 -
Flags: review?(bzbarsky) → review+
|
|
Assignee | |
Comment 4•12 years ago
|
||
Flags: in-testsuite-
|
|
||
Comment 5•12 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla24
You need to log in
before you can comment on or make changes to this bug.
Description
•