Closed Bug 884576 Opened 6 years ago Closed 6 years ago
Make some ns
Block Frame methods infallible
I noticed a few helper-methods in nsBlockFrame that are now effectively infallible but still return nsresult (& always return NS_OK). Filing this bug to clean those up.
Here are the methods tweaked in this bug's upcoming patch, and the history of them being effectively-infallible: * nsBlockFrame::ReflowPushedFloats has been infallible since its last NS_ENSURE_SUCCESS was removed in 2010 (though it was named ReflowFloatContinuations back then): http://hg.mozilla.org/mozilla-central/rev/cf3a58fef285#l1.130 * nsBlockFrame::PrepareResizeReflow has been infallible since the CVS days: http://mxr.mozilla.org/firefox/source/layout/generic/nsBlockFrame.cpp#1505 * nsBlockFrame::SplitLine() has been infallible since its last non-NS_OK return value was removed in bug 851848: https://hg.mozilla.org/mozilla-central/rev/a68dd0799cf6#l1.21  (That renaming happened in http://hg.mozilla.org/mozilla-central/rev/8ab7ef79b673 )
Assignee: nobody → dholbert
Status: NEW → ASSIGNED
Attachment #764423 - Flags: review?(bzbarsky)
Comment on attachment 764423 [details] [diff] [review] fix v1 r=me
Attachment #764423 - Flags: review?(bzbarsky) → review+
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla24
You need to log in before you can comment on or make changes to this bug.