884576 - Make some nsBlockFrame methods infallible

Status: RESOLVED FIXED

(Core :: Layout: Block and Inline, defect)

Description

[Daniel Holbert [:dholbert]]

I noticed a few helper-methods in nsBlockFrame that are now effectively infallible but still return nsresult (& always return NS_OK).

Filing this bug to clean those up.

Comment 1

[Daniel Holbert [:dholbert]]

Here are the methods tweaked in this bug's upcoming patch, and the history of them being effectively-infallible:

* nsBlockFrame::ReflowPushedFloats has been infallible since its last NS_ENSURE_SUCCESS was removed in 2010 (though it was named ReflowFloatContinuations back then[1]):
  http://hg.mozilla.org/mozilla-central/rev/cf3a58fef285#l1.130

* nsBlockFrame::PrepareResizeReflow has been infallible since the CVS days:
   http://mxr.mozilla.org/firefox/source/layout/generic/nsBlockFrame.cpp#1505


* nsBlockFrame::SplitLine() has been infallible since its last non-NS_OK return value was removed in bug 851848:
   https://hg.mozilla.org/mozilla-central/rev/a68dd0799cf6#l1.21


[1] (That renaming happened in http://hg.mozilla.org/mozilla-central/rev/8ab7ef79b673 )

Comment 2

[Daniel Holbert [:dholbert]]

Attachment: fix v1

Comment 3

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 764423 [details] [diff] [review]
fix v1

r=me

Comment 4

[Daniel Holbert [:dholbert]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/b660582ee451

Comment 5

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/b660582ee451