884580 - Links to www.thimble/editor should link to root

Status: RESOLVED FIXED

(Webmaker Graveyard :: Thimble, defect)

Description

[Brett Gaylor [:brett]]

Currently getting a "cannot get" on links here:
https://thimble.webmaker.org/en-US/editor

Thats a well used URL. It should link to the root.

Comment 1

[Jon Buckley [:jbuck]]

We should redirect like we did with webmaker.org.

Comment 2

[Pomax]

I'm pretty sure we put that route in already: https://github.com/mozilla/thimble.webmaker.org/blob/master/app.js#L125

So the question is why it's broken.

Comment 3

[Pomax]

sorry.. that's for projects. /en-US/Editor should indeed just point to the root.

Comment 4

[Pomax]

Attachment: https://github.com/mozilla/thimble.webmaker.org/pull/144

Comment 5

[Jon Buckley [:jbuck]]

Comment on attachment 764438 [details] [review]
https://github.com/mozilla/thimble.webmaker.org/pull/144

I'd rather do it like https://github.com/mozilla/webmaker.org/blob/master/routes/redirect.js#L53-L55 and just redirect everything under "/en-US" to "/"

Comment 6

[Pomax]

while that makes sense for popcorn, it doesn't for thimble. Thimlbe only has two en-US routes: the one to editor, which should point to /, and one for specific projects, which under no circumstance should be allowed to magically switch to /, (because the links to those projects came about by working with partners and we can't just change the links without letting them know).

Since we already have https://github.com/mozilla/thimble.webmaker.org/blob/master/app.js#L125 for projects, adding a more generic route to kick in after that is overkill if we only have one other route to catch. I'd rather keep it explicit in this case.

Comment 7

[Jon Buckley [:jbuck]]

I mispoke, what happens is that route captures everything after with /en-US(.*) and then redirects you to $1. What's nice about it is that it will do a permanent redirect of anything that we may have missed.

Comment 8

[Pomax]

right, but then it's still wrong. /en-US/editor should not point to /editor, but to /, while en-US/projects/zoo-small/edit should indeed point to /projects/zoo-small/edit, so we'd still end up with two separate rules to deal with this. I'd rather not add a mystery route for things we missed, I'd greatly prefer a bug report that says "we tried this link and it doesn't work!" rather than adding a blanket rule.

Comment 9

[[github robot]]

Commit pushed to master at https://github.com/mozilla/thimble.webmaker.org

https://github.com/mozilla/thimble.webmaker.org/commit/ac85a4c082027e5b24e74140fc13158caeee6776
Merge pull request #144 from Pomax/bug884580

legacy route for main page