Links to www.thimble/editor should link to root

RESOLVED FIXED

Status

RESOLVED FIXED
6 years ago
5 years ago

People

(Reporter: brett, Assigned: pomax)

Tracking

Details

Attachments

(1 attachment)

(Reporter)

Description

6 years ago
Currently getting a "cannot get" on links here:
https://thimble.webmaker.org/en-US/editor

Thats a well used URL. It should link to the root.

Comment 1

6 years ago
We should redirect like we did with webmaker.org.
(Assignee)

Comment 2

6 years ago
I'm pretty sure we put that route in already: https://github.com/mozilla/thimble.webmaker.org/blob/master/app.js#L125

So the question is why it's broken.
(Assignee)

Comment 3

6 years ago
sorry.. that's for projects. /en-US/Editor should indeed just point to the root.
(Assignee)

Comment 6

6 years ago
while that makes sense for popcorn, it doesn't for thimble. Thimlbe only has two en-US routes: the one to editor, which should point to /, and one for specific projects, which under no circumstance should be allowed to magically switch to /, (because the links to those projects came about by working with partners and we can't just change the links without letting them know).

Since we already have https://github.com/mozilla/thimble.webmaker.org/blob/master/app.js#L125 for projects, adding a more generic route to kick in after that is overkill if we only have one other route to catch. I'd rather keep it explicit in this case.

Comment 7

6 years ago
I mispoke, what happens is that route captures everything after with /en-US(.*) and then redirects you to $1. What's nice about it is that it will do a permanent redirect of anything that we may have missed.
(Assignee)

Comment 8

6 years ago
right, but then it's still wrong. /en-US/editor should not point to /editor, but to /, while en-US/projects/zoo-small/edit should indeed point to /projects/zoo-small/edit, so we'd still end up with two separate rules to deal with this. I'd rather not add a mystery route for things we missed, I'd greatly prefer a bug report that says "we tried this link and it doesn't work!" rather than adding a blanket rule.

Updated

6 years ago
Attachment #764438 - Flags: review- → review+
(Assignee)

Updated

6 years ago
Status: NEW → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
Attachment mime type: text/plain → text/x-github-pull-request
You need to log in before you can comment on or make changes to this bug.