884617 - Explicitly --disable-threadsafe for the SM(r) build on TBPL

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect)

Description

[Terrence Cole [:terrence]]

We have uncovered several issues recently that were not caught by the rooting analysis because it runs in a significantly different configuration. We should investigate allowing the root analysis to work in threadsafe builds so that we can catch more of these issues.

Comment 1

[Terrence Cole [:terrence]]

When we switch to --enable-threadsafe as the default, these builds will start silently succeeding.

Comment 2

[Steve Fink [:sfink] [:s:]]

Attachment: Dynamic rooting analysis should disable threadsafe explicitly

Ben: I know it's a little weird for you to be reviewing a configure flag change for a spidermonkey shell test build, but it's just preserving existing behavior in preparation for a change of defaults.

Comment 3

[[e-mail] (:bhearsum)]

Comment on attachment 815600 [details] [diff] [review]
Dynamic rooting analysis should disable threadsafe explicitly

Review of attachment 815600 [details] [diff] [review]:
-----------------------------------------------------------------

In the future, I think it's probably fine for you to get review from someone who understands what these builds need to be and/or what the flags do. But I'm also fine to rubberstamp them.

Comment 4

[Steve Fink [:sfink] [:s:]]

Equivalent patch landed as part of bug 927204.