Explicitly --disable-threadsafe for the SM(r) build on TBPL

RESOLVED FIXED in mozilla28

Status

()

RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: terrence, Assigned: sfink)

Tracking

Trunk
mozilla28
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [qa-])

Attachments

(1 attachment)

(Reporter)

Description

5 years ago
We have uncovered several issues recently that were not caught by the rooting analysis because it runs in a significantly different configuration. We should investigate allowing the root analysis to work in threadsafe builds so that we can catch more of these issues.
(Reporter)

Comment 1

5 years ago
When we switch to --enable-threadsafe as the default, these builds will start silently succeeding.
Summary: Run the root analysis in threadsafe builds → Explicitly --disable-threadsafe for the SM(r) build on TBPL
(Reporter)

Updated

5 years ago
Assignee: general → sphink
(Assignee)

Comment 2

5 years ago
Created attachment 815600 [details] [diff] [review]
Dynamic rooting analysis should disable threadsafe explicitly

Ben: I know it's a little weird for you to be reviewing a configure flag change for a spidermonkey shell test build, but it's just preserving existing behavior in preparation for a change of defaults.
Attachment #815600 - Flags: review?(bhearsum)
(Reporter)

Updated

5 years ago
Blocks: 924986
Comment on attachment 815600 [details] [diff] [review]
Dynamic rooting analysis should disable threadsafe explicitly

Review of attachment 815600 [details] [diff] [review]:
-----------------------------------------------------------------

In the future, I think it's probably fine for you to get review from someone who understands what these builds need to be and/or what the flags do. But I'm also fine to rubberstamp them.
Attachment #815600 - Flags: review?(bhearsum) → review+
(Assignee)

Comment 4

5 years ago
Equivalent patch landed as part of bug 927204.
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla28

Updated

5 years ago
Whiteboard: [qa-]
You need to log in before you can comment on or make changes to this bug.