Closed
Bug 884625
Opened 11 years ago
Closed 11 years ago
SimplePush: Convert all vars to let in push related files.
Categories
(Core :: DOM: Push Subscriptions, defect)
Tracking
()
RESOLVED
FIXED
mozilla27
People
(Reporter: nsm, Assigned: nsm)
References
Details
Attachments
(1 file, 1 obsolete file)
|
21.96 KB,
patch
|
dougt
:
review+
|
Details | Diff | Splinter Review |
No description provided.
|
||
Updated•11 years ago
|
Component: DOM → DOM: Device Interfaces
|
Assignee | |
Comment 1•11 years ago
|
||
This is a simple bug, files are in dom/push/src
Whiteboard: [good first bug][mentor=nsm]
(In reply to Nikhil Marathe from comment #1)
> This is a simple bug, files are in dom/push/src
Hi Nikhil,
This looks like it would be a good first bug for me. I don't see a way to assign it to myself though - can you assign it to me.
Thanks!
|
|
Assignee | |
Updated•11 years ago
|
Assignee: nsm.nikhil → kevnchu
|
||
Comment 3•11 years ago
|
||
Any update on this ? I can take this ticket from you if you haven't yet tackled it.
I attached my changes but was never able to get the tests running. Jakub, you're welcome to take this over if you want.
|
||
Updated•11 years ago
|
Component: DOM: Device Interfaces → DOM: Push Notifications
|
|
Assignee | |
Updated•11 years ago
|
Assignee: kevnchu → nsm.nikhil
|
|
Assignee | |
Comment 7•11 years ago
|
||
Comment on attachment 779005 [details] [diff] [review]
Patch
Doesn't apply cleanly to tree.
Attachment #779005 -
Attachment is obsolete: true
|
||
Comment 8•11 years ago
|
||
Comment on attachment 805517 [details] [diff] [review]
Convert vars to let in SimplePush module.
make sure we don't leak and still work.
Attachment #805517 -
Flags: review?(doug.turner) → review+
|
|
Assignee | |
Comment 9•11 years ago
|
||
Whiteboard: [good first bug][mentor=nsm]
|
||
Comment 10•11 years ago
|
||
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla27
You need to log in
before you can comment on or make changes to this bug.
Description
•