884627 - [B2G][Calendar] After editing reminder time on existing event, Done cannot be selected

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::Calendar, defect, P1)

Description

[Angela Hubenya]

Description:
When user attempts to edit the reminder time on an existing calendar event, he is not able to select the Done option and is not returned back to event details. 

Repro Steps:
1) Updated to Unagi Build ID: 20130618070211
2) Go to Calendar application
3) Create an event
4) Select that event to view detail
5) Select Edit
6) Change “Remind me” time to another time 
7) Select Done

Actual:
Selecting Done does not take user back to event details

Expected:
User is taken back to event details

Notes: After selecting Done, and then the < arrow twice and return to event, notice that reminder time changed. 
Issues reproduces for Offline and Online events. 

Repro frequency: 100%

Environmental Variables
Gecko: http://hg.mozilla.org/releases/mozilla-b2g18/rev/a199b1109860
Gaia: 3e9090894daaa1c7f894a1dcc1026b21f889eadc
Platform Version: 18.0

Comment 1

[Jason Smith [:jsmith]]

Pretty sure this is a regression from bug 876794.

Comment 2

[Jason Smith [:jsmith]]

We also might want to back out bug 876794 in general. There's at least two regressions I've found (one I've yet to file).

Comment 3

[James Lal [:lightsofapollo]]

Can you provide a logcat in theory its possible that bug 876794 caused these problems but it only touches the cases that involve all day accounts.

Comment 4

[James Lal [:lightsofapollo]]

Figured this out- its unrelated to the above bug but definitively a regression related to 867797 where the redirect code path didn't update correctly.

Comment 5

[Jason Smith [:jsmith]]

(In reply to James Lal [:lightsofapollo] from comment #4)
> Figured this out- its unrelated to the above bug but definitively a
> regression related to 867797 where the redirect code path didn't update
> correctly.

Ah that makes sense. Switching bugs then in the blocking field.

Comment 6

[Jason Smith [:jsmith]]

Fixed by backout of bug 867797.

Comment 7

[John Ford [:jhford] CET/CEST Berlin Time]

The fix in comment 6 has also been applied to branch.  marking branches to reflect this.

Comment 8

[Angela Hubenya]

I was able to select Done after changing the reminder time when editing event on today's v1.1 build.

Although it returned me to the whole calendar and not event details. Is that a regression or has there been a change in design? 

Unagi Build ID: 20130624070224
Gecko: http://hg.mozilla.org/releases/mozilla-b2g18/rev/62049a1c5d36
Gaia: 885b874029d8143035765ae903c147a9415fcc52
Platform Version: 18.1

Comment 9

[Jason Smith [:jsmith]]

(In reply to Angela Hubenya from comment #8)
> I was able to select Done after changing the reminder time when editing
> event on today's v1.1 build.
> 
> Although it returned me to the whole calendar and not event details. Is that
> a regression or has there been a change in design? 
> 

Change in design. We landed a patch on 1.1 to change the behavior to go back to the whole calendar instead of the event details when saving an event.

Comment 10

[Angela Hubenya]

Gotcha! Thanks

Comment 11

[Angela Hubenya]

Verified Fixed per comment 8