Render markdown in event details page

RESOLVED FIXED

Status

RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: jon, Unassigned)

Tracking

Details

(Reporter)

Description

5 years ago
Currently everything is being double-escaped because I enabled global autoescaping on webmaker.org and that conflicts with the local escaping already done in the template.

Event details will work fine, they just look ugly at the moment: https://webmaker.mofostaging.net/events/16
(Reporter)

Comment 1

5 years ago
In https://github.com/mozilla/webmaker-events/commit/1da9523251ff4543b9c68b6caadd0a9bf46b59f2 I removed the extra escape filters, but that didn't fix the problem because the markdown filter outputs HTML, which then gets escaped. As a temporary fix I've removed the markdown filter, but we should look at adding it again once we have a way to escape the HTML it outputs. *cough* bleach *cough*.
(Reporter)

Comment 2

5 years ago
https://github.com/mozilla/webmaker-events/commit/e83c54aa25b625e4160899ea9443cf49dd613f4d is the commit where I removed the markdown filter.

Updated

5 years ago
Blocks: 884033
(Reporter)

Updated

5 years ago
Summary: Fix event details HTML double-escaping → Render markdown in event details page
(Reporter)

Comment 3

5 years ago
To be clear, there's no double escaped HTML on the events page, we simply don't render Markdown at the moment. This isn't critical to fix, just a nice to have.
(Reporter)

Comment 4

5 years ago
Unblocking this, because un-rendered Markdown isn't a bug deal, and it's something we can't easily solve today.
No longer blocks: 884033

Comment 5

5 years ago
Resolved using 'safe' filter in webmaker-events#ab32475.
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.