884644 - Render markdown in event details page

Status: RESOLVED FIXED

(Webmaker Graveyard :: webmaker.org, defect)

Description

[Jon Buckley [:jbuck]]

Currently everything is being double-escaped because I enabled global autoescaping on webmaker.org and that conflicts with the local escaping already done in the template.

Event details will work fine, they just look ugly at the moment: https://webmaker.mofostaging.net/events/16

Comment 1

[Jon Buckley [:jbuck]]

In https://github.com/mozilla/webmaker-events/commit/1da9523251ff4543b9c68b6caadd0a9bf46b59f2 I removed the extra escape filters, but that didn't fix the problem because the markdown filter outputs HTML, which then gets escaped. As a temporary fix I've removed the markdown filter, but we should look at adding it again once we have a way to escape the HTML it outputs. *cough* bleach *cough*.

Comment 2

[Jon Buckley [:jbuck]]

https://github.com/mozilla/webmaker-events/commit/e83c54aa25b625e4160899ea9443cf49dd613f4d is the commit where I removed the markdown filter.

Comment 3

[Jon Buckley [:jbuck]]

To be clear, there's no double escaped HTML on the events page, we simply don't render Markdown at the moment. This isn't critical to fix, just a nice to have.

Comment 4

[Jon Buckley [:jbuck]]

Unblocking this, because un-rendered Markdown isn't a bug deal, and it's something we can't easily solve today.

Comment 5

[hike]

Resolved using 'safe' filter in webmaker-events#ab32475.