Closed Bug 884677 Opened 11 years ago Closed 10 years ago

Reduce the number of magic numbers in browser_selection_urlbar.js

Categories

(Firefox for Metro Graveyard :: Tests, defect, P3)

Product:
Firefox for Metro Graveyard
Component:
Tests
Platform:
x86_64
Windows 8.1
Type:
defect

Tracking

(Not tracked)

Status:
RESOLVED INCOMPLETE

People

(Reporter: fryn, Unassigned)

References

Details

(Whiteboard: [selection] p=3) 

The fix in bug 873251 broke browser_selection_urlbar.js due to that test's usage of magic numbers and fragile offsets.

:tabraldes noted that the following block needs fixing:
https://mxr.mozilla.org/mozilla-central/source/browser/metro/base/tests/mochitest/browser_selection_urlbar.js#51
No longer blocks: 873251
Summary: Fix browser_selection_urlbar.js and reduce the number of magic numbers in it → Reduce the number of magic numbers in browser_selection_urlbar.js
Blocks: metrov1defect&change
Summary: Reduce the number of magic numbers in browser_selection_urlbar.js → Defect - Reduce the number of magic numbers in browser_selection_urlbar.js
Whiteboard: feature=defect c=tbd u=tbd p=0
Priority: -- → P4
Priority: P4 → --
No longer blocks: metrov2defect&change
Summary: Defect - Reduce the number of magic numbers in browser_selection_urlbar.js → Reduce the number of magic numbers in browser_selection_urlbar.js
Whiteboard: feature=defect c=tbd u=tbd p=0 → [defect] p=0
Whiteboard: [defect] p=0 → [defect] [selection] p=0
Blocks: 957244
OS: Windows 8 Metro → Windows 8.1
Whiteboard: [defect] [selection] p=0 → [defect] [selection] p=3
Priority: -- → P3
Target Milestone: --- → Firefox 30
Whiteboard: [defect] [selection] p=3 → [selection] p=3 r=ff30
Target Milestone: Firefox 30 → ---
Assignee: nobody → msamuel
Status: NEW → ASSIGNED
Priority: P3 → P2
QA Contact: kamiljoz
Whiteboard: [selection] p=3 r=ff30 → [selection] p=3 s=it-30c-29a-28b.2 r=ff30
Status: ASSIGNED → NEW
Priority: P2 → --
Whiteboard: [selection] p=3 s=it-30c-29a-28b.2 r=ff30 → [selection] p=3
Priority: -- → P3
Assignee: msamuel → nobody
QA Contact: kamiljoz
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → INCOMPLETE
You need to log in before you can comment on or make changes to this bug.