884720 - [Music] [Video] Picker for video/audio plays automatically

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::Music, defect, P1)

Description

[Paul Yang [:pyang] (away)]

When using picker for music/video, for example, attach music in MMS, the track is played automatically when it is selected.

No sure if user would feel annoyed because of sound unexpected.

EXPECT:
- When using media picker, it will not play the media unless user press play button.
ACTUAL:
- Media starts automatically

Comment 1

[Paul Yang [:pyang] (away)]

https://www.dropbox.com/s/c9rrz0ymxvg0osw/email-attachments.pdf
Above is ux doc for email attachment picker, no definition for this behavior.

Comment 2

[Paul Yang [:pyang] (away)]

There is a issue related to this one.
When media is very short, user may not be able to click the pick icon, since it's on view page.

Comment 3

[Dominic Kuo [:dkuo]]

Thanks Paul, it's really hard to select one short video/audio before the preview ends, and uauslly MMS only allow to attach small files which also means short video/audio, we better fix this.

Rob, I think the problem is when picking video/audio, users are unable to stay in the preview if a short video/audio ends quickly. We probably can let the users decide to start the preview on their own or stay in the preview if a video/audio ends, can you help to give some inputs on this? thanks.

Comment 4

[Jason Smith [:jsmith]]

Rob - Can you also provide input on whether you think is a critical blocker for leo from a UX perspective?

Comment 5

[Lukas Blakk [:lsblakk] use ?needinfo]

Blocking for now on the auto-play, we would ship without a revamped UI.

Comment 6

[Rob MacDonald [:robmac]]

Apologies for this gap in the documentation. Paul's assumption in Comment 9 is correct - When using media picker, there is no audio or video playback unless the user presses the play button. Due to the usability issues this creates, and the annoyances, I would consider this a blocker from the UX perspective.

Comment 7

[Alex Keybl [:akeybl]]

Dominic - can we make the change requested in comment 6? That is, to not auto-play video/audio?

Comment 8

[Dominic Kuo [:dkuo]]

Alex, yes, and sorry I didn't notice this issue has become a 1.1 QE4/QE5 bug, I will start to work on this, thanks.

Comment 9

[Dominic Kuo [:dkuo]]

Attachment: No autoplay for music and video pickers

Jim,

This is a patch that modified the music and video pickers to not to autoplay after select one audio/video to preview as comment 6 described, also note the preview in the two pickers will reset to the beginning when it ends and without exiting to the previous list, this is for some very short audio/video that we can stay in the preview and tap the done/choice button, would you please review this? thanks.

Comment 10

[Jim Porter (:squib)]

I'm having trouble testing this on the device... is there anything special I need to do? If not, maybe there's just something weird on my end. If so, I think this is ok to land with my review comments over on github.

Comment 11

[Jason Smith [:jsmith]]

(In reply to Jim Porter (:squib) from comment #10)
> I'm having trouble testing this on the device... is there anything special I
> need to do? If not, maybe there's just something weird on my end. If so, I
> think this is ok to land with my review comments over on github.

Testing-wise - try this:

1. Go to http://mozilla.github.io/qa-testcase-data/webapi/filemanagement/fileUploadTest.html in the browser
2. Select Browser Under Upload Single File with No Filter
3. Select Music or Video (depending on what you are testing)

That should allow you to verify the behavior of this patch.

Comment 12

[Jim Porter (:squib)]

Thanks for the tips. My problem was actually lower-level than that (my phone wasn't booting, and I needed to call "make delete-databases"), but now things are working there. However, going to that page and clicking "Browse" doesn't do anything for me, either with b2g-desktop or on the device (an Unagi). Logcat doesn't show anything relevant either.

Comment 13

[Jim Porter (:squib)]

If I try clicking on the button under "Upload Single File with Audio Filter", I get this (from b2g-desktop):

Timestamp: 07/29/2013 05:10:22 PM
Error: TypeError: app is null
Source File: app://system.gaiamobile.org/js/activities.js
Line: 80

Comment 14

[Jason Smith [:jsmith]]

(In reply to Jim Porter (:squib) from comment #13)
> If I try clicking on the button under "Upload Single File with Audio
> Filter", I get this (from b2g-desktop):
> 
> Timestamp: 07/29/2013 05:10:22 PM
> Error: TypeError: app is null
> Source File: app://system.gaiamobile.org/js/activities.js
> Line: 80

On my unagi device on b2g18 on 7/29, I'm not getting that. I'm seeing the music app appearing allowing me to select a song.

Comment 15

[Jim Porter (:squib)]

Comment on attachment 777989 [details]
No autoplay for music and video pickers

Ok, this works now that I'm using b2g18 instead of a b2g from mozilla-central.

Comment 16

[bhavana bajaj [:bajaj]]

dkuo, is this ready to land ?

Comment 17

[Dominic Kuo [:dkuo]]

Yes, and it's because I found one minor issue and fixed it before I landed it.

Landed on master: da606facb28a36de24b884a2c3518d6a76f27e85

Comment 18

[Dominic Kuo [:dkuo]]

Uplifted commit da606facb28a36de24b884a2c3518d6a76f27e85 to
v1-train: 5a7a243bb04c1a921cca51fee42b8d8d71626bf6

Comment 19

[sbogati]

Issue do not reproduces on Leo.
Environmental  Variables:
Build ID: 20130805071207
Gecko: http://hg.mozilla.org/releases/mozilla-b2g18/rev/a2a9b89ef5ee
Gaia: 45f6a739b09292e16717fb21003386c914ca29c2
Media did not start automatically unless user hit the play button.

Comment 20

[Tim Guan-tin Chien [:timdream] (please needinfo)]

v1.1.0hd: 5a7a243bb04c1a921cca51fee42b8d8d71626bf6

Comment 21

[Paul Yang [:pyang] (away)]

Verify by pvt build 20130802
Media picker doesn't play automatically