884722 - [MMS] amr file can be attached, but can't be viewed

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Music, defect)

Description

[Paul Yang [:pyang] (away)]

Precondition:
- Have one AMR audio file in sdcard
- latest v1-train(6/18)

STR:
1. Open message app
2. Create a new message
3. Press attach icon, select music
4. Pick target AMR sample, check if it is back to message app and has a preview icon
5. Tap preview icon
6. Tap "view" in menu

EXPECT:
Audio file can be previewed

AUTUAL:
A warning page pop-up and indicate it's unsupported type

Comment 1

[Corey Frang [:gnarf]]

:djf: The music app needs to be able to open amr files also.

It finds them to "pick", and you can listen, but not for opening.

Requesting leo - This pretty much blocks audio support for MMS

Comment 2

[Dominic Kuo [:dkuo]]

Currently the open activity of Music does not support amr files, it should be easy to enable it by adding "audio/amr"(probably also "audio/3gpp") to the activities filters of open in manifest.webapp of Music app.

Comment 3

[Corey Frang [:gnarf]]

I tried that, and even after a `make reset-gaia` it still didn't want to open in the music player.

I was hoping that someone else could look at it.  Thanks for taking it!

Comment 4

[David Flanagan [:djf]]

I have no idea what an AMR file is, but I agree that if the music app can play them, then it should be able to open them.

Corey: if the MMS app is passing a type with the open activity, you could try just taking that out.

Dominic: I remember code in a couple of places (maybe it was bluetooth related) that tried to determine file type based on filename extension. Is there anything like that in the open activity?

Comment 5

[Corey Frang [:gnarf]]

(In reply to David Flanagan [:djf] from comment #4)
> Corey: if the MMS app is passing a type with the open activity, you could
> try just taking that out.

Opening for everything else passes type, this isn't going to be a problem in sms from my pov, Music should listen for the types it can play.

Comment 6

[Dominic Kuo [:dkuo]]

(In reply to Corey Frang [:gnarf] [:gnarf37] from comment #3)
> I tried that, and even after a `make reset-gaia` it still didn't want to
> open in the music player.

I can successfully invoke the music open activity after:
1. adding "audio/amr" to manifest.webapp
2. make reset-gaia
Probabaly "make clean" first then try again?

But due to bug 877482, you should see music crashes just like gallery when users are trying to view their mms attachments, video is the same.

(In reply to David Flanagan [:djf] from comment #4)
> Dominic: I remember code in a couple of places (maybe it was bluetooth
> related) that tried to determine file type based on filename extension. Is
> there anything like that in the open activity?

Yes, shared/js/mime_mapper.js is what you are talking about, both email and bluetooth transfer apps use it to avoid the unsure mimetype then delegate a correct open activity.
MMS should also use mime_mapper.js because it's possible to receive a MMS message with unsupported/unsure mimetype, but I wonder if the MMS implementation in gecko will just correct blob.type for gaia so probably we don't need mime_mapper.js in MMS.

I think the real problem here is, "audio/amr" is not in the manifest.webapp of music. And in case to open some *.amr files for the apps that use mime_mapper.js, we should also add the mimetype-extension mappings for amr in mime_mapper.js. For the part that MMS includes mime_mapper.js, we can treat it as a followup casue there should be some UX works for error handlings I guess.

Comment 7

[Dominic Kuo [:dkuo]]

Attachment: support amr for music open activity

This patch modified manifest.webapp and mime_mapper.js as I said in comment 6, except the part that MMS should use mime_mapper.js.

Corey, I am not sure if MMS will receives some files with unsupported/unsure mimetype, like "application/octet-stream" is really common in email and bluetooth transfer apps. If so, we should also use MimeMapper, and if it still failed to find a proper mimetype, we should prompt "There is no application available to open this file type." just like MMS did in activity.onerror.

Comment 8

[Corey Frang [:gnarf]]

(In reply to Dominic Kuo [:dkuo] from comment #7)
> Corey, I am not sure if MMS will receives some files with unsupported/unsure
> mimetype, like "application/octet-stream" is really common in email and
> bluetooth transfer apps. If so, we should also use MimeMapper, and if it
> still failed to find a proper mimetype, we should prompt "There is no
> application available to open this file type." just like MMS did in
> activity.onerror.

I've sent myself a lot of stuff over the mms network, haven't seen an app/octet-stream yet...

I'm thinking that it will be less common here.

Comment 9

[Corey Frang [:gnarf]]

Comment on attachment 765247 [details]
support amr for music open activity

This works after doing a reset-gaia

Comment 10

[Dominic Kuo [:dkuo]]

(In reply to Corey Frang [:gnarf] [:gnarf37] from comment #8)
> I've sent myself a lot of stuff over the mms network, haven't seen an
> app/octet-stream yet...
> 
> I'm thinking that it will be less common here.

Okay, sounds like MMS doesn't need MimeMapper for now, if we find some unsupported mimetypes in the future, we can fix that in another followup.

And I have asked Tim to review my patch and got r+, I am landing it and thanks Tim!

Comment 11

[Dominic Kuo [:dkuo]]

Landed on master: 1b6752d91ee604fe62bb42c2c03c80724b920b98

Comment 12

[Gareth Aye [:gaye] (back from PTO)]

Uplifted 1b6752d91ee604fe62bb42c2c03c80724b920b98 to:
v1-train: 75c0a7fd3513a896db608fa04466265db9611e9e

Comment 13

[John Ford [:jhford] CET/CEST Berlin Time]

v1.1.0hd: 75c0a7fd3513a896db608fa04466265db9611e9e

Comment 14

[sarsenyev]

Verified this bug is fixed, the AMR file is playable in the "Preview" mode
 
Environmental  Variables:
Build ID: 20130730070228
Gecko: http://hg.mozilla.org/releases/mozilla-b2g18/rev/1fe3339e3d96
Gaia: 6221737cb50d6e8435ac5d3fe3b7e2788bd8a37c
Platform Version: 18.1