884725 - [Facebook] When clicking on facebook sync error notification, Dialer App. disappears after opening.

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Contacts, defect, P1)

Description

[Leo]

Attachment: screen shot

1. Title : When clicking on facebook sync error notification, Dialer App. disappears after opening.
2. Precondition : Both wifi and 3G data are enabled. Sync facebook contacts.
3. Tester's Action : The phone after 24h in idle shown facebook sync error in notification.
4. Detailed Symptom (ENG.) : When clicking on facebook sync error notification, Dialer App. disappears after opening.
And Dialer App. is not started by clicking on the Dialer App.'s icon.
Please see the attached video file.
5. Expected : When clicking on facebook sync error notification, Dialer App. should not be opened.
6. Reproducibility: N
	1) Frequency Rate : 1
7.Gaia v1-train : Reproduced
8.Gaia Revision: 4d10e1297b859cacc174c0a54af61a7678d7c32d
9.Personal email id:  [e-mail]

Comment 1

[Germán Toro del Valle (:gtorodelvalle)]

Hi guys! I am sorry but after a lot of testing I was not able to reproduce this bug. What I did was to set the 'facebookSyncPeriod' to 1 / 60 and the airplane mode on to try to force the bug but the Facebook synchronization just gets rescheduled over and over again. I left the phone for a whole day rescheduling.

BTW, I also had to set the Facebook applicationId to '323630664378726' because otherwise I get a Facebook authentication error requesting the correct app id :-(

What I'll do today is to follow the steps as stated in comment 1, this is to synchronize my Facebook contacts and leave the phone idle for 24 hours. I'll get back to you tomorrow with the results.

Any additional input is more than appreciated.

Comment 2

[Wayne Chang [:wchang]]

Hi German, thanks for the info, please do follow the original bug description I suspect have facebook contacts synced plays a part in this bug.

Hi Leo,
In the report you have Reproducibility: N - does this mean you cannot reproduce this bug any more? If so it may be hard for us to debug. How were you able to shoot the video knowing the bug would appear?

Comment 3

[Leo]

I also cannot reproduce this issue any more.
The video was taken during the facebook sync error shoot.
But, this issue can be happened again at any time.
Please check this issue again.

Thanks!

Comment 4

[Germán Toro del Valle (:gtorodelvalle)]

Hi guys! I have been digging into this and forced the notification to appear forcing the syncError() function to execute whenever a new synchronization alarm fires. Although I cannot reproduce the error regarding the Communication app not being able to be re-started, I found another issue in the code related to the hash management. Please see https://github.com/mozilla-b2g/gaia/blob/master/apps/communications/dialer/js/dialer.js#L70 (#recents-view refers to an outdated hash, right now this hash should be #call-log-view).

Apart from this, it has little sense to open the Communication app showing the Call Log when a Facebook synchronization error is notified and the user clicks on it. This is why I included some code to disambiguate this error and to open the Contacts app in the Communications app.

I'll ask José Manuel to review the code but if you wish you can also try it using any of the following patches:
  - for master: https://github.com/mozilla-b2g/gaia/commit/9dbc0d1378b6956380dcbfabf430e56a6ee5c70f
  - for v1-train: https://github.com/mozilla-b2g/gaia/commit/520b2d0a229379cf76cbd3053fdb721a3f38010a

To force the notification you also have to include:

syncError();
return;

at the beginning of the handleAlarm() function in fb_sync.init.js.

Comment 5

[Germán Toro del Valle (:gtorodelvalle)]

As a side not, just inform you that with the latest builds for v1-train (Gecko-9f29c9b Gaia-08f5ca1) and master (Gecko-d13c936 Gaia-4ff0848) the notification messages seem not to be notified to the corresponding handlers/listener so you'll have to use a previous one ;-)

Comment 6

[Germán Toro del Valle (:gtorodelvalle)]

Attachment: Associated PR.

Comment 7

[Jose Manuel Cantera]

Comment on attachment 767698 [details]
Associated PR.

it works

thanks

Comment 8

[Germán Toro del Valle (:gtorodelvalle)]

Merged in master: https://github.com/mozilla-b2g/gaia/commit/cca45bb36d8b579958520981f224de75c75283e4

Comment 9

[Gareth Aye [:gaye] (back from PTO)]

Uplifted cca45bb36d8b579958520981f224de75c75283e4 to:
v1-train: c34eff078ba8c2bf347382fabe0ad09df681d6f9

Comment 10

[John Ford [:jhford] CET/CEST Berlin Time]

v1.1.0hd: c34eff078ba8c2bf347382fabe0ad09df681d6f9