884730 - Add an --exporter switch to importxml

Status: UNCONFIRMED

(Bugzilla :: Bug Import/Export & Moving, enhancement)

Description

[Antoine Turmel [:GeekShadow]]

Currently each bug you want to import needs to have an exporter="" field in xml.
I ran a backup of bugs but I don't have this. So it would be nice to have a switch in importxml script to input the exporter.

Comment 1

[Antoine Turmel [:GeekShadow]]

Attachment: v1 - add the --exporter flag

My patch work with --exporter=[e-mail] but not --export [e-mail]
also it's my first time on Perl.

Comment 2

[Frédéric Buclin]

Comment on attachment 764764 [details] [diff] [review]
v1 - add the --exporter flag

>+    if (!$exporter) {
>+      $exporter = $default_exporter;
>+    }

Simply write:

my $exporter   = $root->{'att'}->{'exporter'} || $default_exporter;


>     my $exporter_login   = $root->{'att'}->{'exporter'};
>+    
>+    if ($default_exporter) {
>+      $exporter_login = $default_exporter;
>+    }

Same here.


You also forgot to set the exporter around line 1268 if none is specified in the XML file.


Otherwise looks good. :)

Comment 3

[Antoine Turmel [:GeekShadow]]

Attachment: v2 - add the --exporter flag

Comment 4

[Antoine Turmel [:GeekShadow]]

@Frédéric
So what do you think ?

Comment 5

[Frédéric Buclin]

Comment on attachment 765233 [details] [diff] [review]
v2 - add the --exporter flag

>+    my $exporter_login   = $root->{'att'}->{'exporter'}; || $default_exporter;

The code doesn't compile due to the semi-colon before ||.


Also, you must detaint $exporter_login in process_bug(), else importxml.pl crashes:

  Insecure dependency in parameter 5 of DBI::st=HASH(0xa677028)->execute method call while running with -T switch at ./importxml.pl line 1205.


One way to do it is to set $exporter_login = $exporter->login.


Do you want to upload a new patch with these problems fixed or do you want me to do it myself?